]> cat aescling's git repositories - mastodon.git/commitdiff
add an explanatory comment to AccountInteractions
authorSurinna Curtis <ekiru.0@gmail.com>
Wed, 13 Sep 2017 22:42:52 +0000 (17:42 -0500)
committerSurinna Curtis <ekiru.0@gmail.com>
Thu, 14 Sep 2017 02:47:30 +0000 (21:47 -0500)
app/models/concerns/account_interactions.rb

index 4a4265df227ff1b381bd53594d918dc827b12f42..6f69ce1d4b5aff5b8556daa19e19fbe66d2d596d 100644 (file)
@@ -76,6 +76,7 @@ module AccountInteractions
 
   def mute!(other_account, notifications: true)
     mute = mute_relationships.create_with(hide_notifications: notifications).find_or_create_by!(target_account: other_account)
+    # When toggling a mute between hiding and allowing notifications, the mute will already exist, so the find_or_create_by! call will return the existing Mute without updating the hide_notifications attribute. Therefore, we check that hide_notifications? is what we want and set it if it isn't.
     if mute.hide_notifications? != notifications
       mute.hide_notifications = notifications
       mute.save!
This page took 0.020439 seconds and 3 git commands to generate.