]> cat aescling's git repositories - mastodon.git/commit
Replace inline styles with CSS classes (BEM) (#2338)
authorStephen Burgess <stephenburgess8@gmail.com>
Sun, 23 Apr 2017 02:26:55 +0000 (21:26 -0500)
committerEugen <eugen@zeonfederated.com>
Sun, 23 Apr 2017 02:26:55 +0000 (04:26 +0200)
commitcca41ea544fe7de3e7afdc250992a1c6e48d2a31
treea5e2f06b2da112342de7725b85b5a18e0d09ef37
parent532bec6e564884c2bd5b2bcc7cab929f4f2cabf5
Replace inline styles with CSS classes (BEM) (#2338)

* fix(classnames): Status icon style classnames

Take out inline css and put into classnames for the following components: account, avatar, icon button, status action bar, notification.

* fix(status): Move styles from inline to classes for statuses

Move styles to classnames in components.scss for the following components:

display name
media gallery
status
status content
video player

* fix(classnames): Add classnames to rest of components

Take out inline styles and apply them to classnames in the sass for the following components:

button
column back button
slim column back button
collapsable column
dropdown menu
loading indicator
status list

* fix(classnames): Remove all non-dynamic inline styles

Components affected:

autosuggested
permalink
action bar
header
character counter
compose form
emoji dropdown
privacy dropdown
reply indicator
upload form
account auth
followers
getting started
column settings
mutes
settings
reblogs
status checkbox
report
action bar
status
card
boost modal
media modal
video modal

* fix(permalink): Do not lose classname

* fix(tests): Add space back in display name

* fix(status__wrapper): Remove duplicate css name

Remove incorrect style attribute. Remove style attribute all together. Cursor defaults to "auto" when not specified as 'default'.

* fix(nl): do not lose translations
58 files changed:
app/assets/javascripts/components/components/account.jsx
app/assets/javascripts/components/components/autosuggest_textarea.jsx
app/assets/javascripts/components/components/avatar.jsx
app/assets/javascripts/components/components/button.jsx
app/assets/javascripts/components/components/column_back_button.jsx
app/assets/javascripts/components/components/column_back_button_slim.jsx
app/assets/javascripts/components/components/column_collapsable.jsx
app/assets/javascripts/components/components/display_name.jsx
app/assets/javascripts/components/components/dropdown_menu.jsx
app/assets/javascripts/components/components/icon_button.jsx
app/assets/javascripts/components/components/loading_indicator.jsx
app/assets/javascripts/components/components/media_gallery.jsx
app/assets/javascripts/components/components/permalink.jsx
app/assets/javascripts/components/components/status.jsx
app/assets/javascripts/components/components/status_action_bar.jsx
app/assets/javascripts/components/components/status_content.jsx
app/assets/javascripts/components/components/status_list.jsx
app/assets/javascripts/components/components/video_player.jsx
app/assets/javascripts/components/features/account/components/action_bar.jsx
app/assets/javascripts/components/features/account/components/header.jsx
app/assets/javascripts/components/features/account_timeline/components/header.jsx
app/assets/javascripts/components/features/compose/components/autosuggest_account.jsx
app/assets/javascripts/components/features/compose/components/autosuggest_status.jsx
app/assets/javascripts/components/features/compose/components/character_counter.jsx
app/assets/javascripts/components/features/compose/components/compose_form.jsx
app/assets/javascripts/components/features/compose/components/emoji_picker_dropdown.jsx
app/assets/javascripts/components/features/compose/components/navigation_bar.jsx
app/assets/javascripts/components/features/compose/components/privacy_dropdown.jsx
app/assets/javascripts/components/features/compose/components/reply_indicator.jsx
app/assets/javascripts/components/features/compose/components/upload_button.jsx
app/assets/javascripts/components/features/compose/components/upload_form.jsx
app/assets/javascripts/components/features/compose/components/upload_progress.jsx
app/assets/javascripts/components/features/follow_requests/components/account_authorize.jsx
app/assets/javascripts/components/features/followers/index.jsx
app/assets/javascripts/components/features/following/index.jsx
app/assets/javascripts/components/features/getting_started/index.jsx
app/assets/javascripts/components/features/home_timeline/components/column_settings.jsx
app/assets/javascripts/components/features/home_timeline/components/setting_text.jsx
app/assets/javascripts/components/features/mutes/index.jsx
app/assets/javascripts/components/features/notifications/components/column_settings.jsx
app/assets/javascripts/components/features/notifications/components/notification.jsx
app/assets/javascripts/components/features/notifications/components/setting_toggle.jsx
app/assets/javascripts/components/features/reblogs/index.jsx
app/assets/javascripts/components/features/report/components/status_check_box.jsx
app/assets/javascripts/components/features/report/index.jsx
app/assets/javascripts/components/features/status/components/action_bar.jsx
app/assets/javascripts/components/features/status/components/card.jsx
app/assets/javascripts/components/features/status/components/detailed_status.jsx
app/assets/javascripts/components/features/status/index.jsx
app/assets/javascripts/components/features/ui/components/boost_modal.jsx
app/assets/javascripts/components/features/ui/components/column_header.jsx
app/assets/javascripts/components/features/ui/components/column_link.jsx
app/assets/javascripts/components/features/ui/components/columns_area.jsx
app/assets/javascripts/components/features/ui/components/media_modal.jsx
app/assets/javascripts/components/features/ui/components/modal_root.jsx
app/assets/javascripts/components/features/ui/components/video_modal.jsx
app/assets/javascripts/components/locales/nl.jsx
app/assets/stylesheets/components.scss