]>
cat aescling's git repositories - mastodon.git/log
Eugen Rochko [Sat, 9 Sep 2017 14:23:44 +0000 (16:23 +0200)]
Add script to make embedded iframes autosize (#4853)
Eugen Rochko [Sat, 9 Sep 2017 13:09:50 +0000 (15:09 +0200)]
Disable mouse-based pause from #4859 (#4865)
It wasn't working ideally and introduced some annoying false positivies
Eugen Rochko [Sat, 9 Sep 2017 12:53:49 +0000 (14:53 +0200)]
Bump version to 1.6.0rc4
unarist [Sat, 9 Sep 2017 12:16:11 +0000 (21:16 +0900)]
Fix scroll behavior and others on paused timeline (#4864)
Resolved:
* Lot of redundant renders while mouse moving
* Scroll jumping when timeline loaded
* Scroll position isn't kept when statuses below the scrollTop was deleted then new status arrived
Unresolved:
* Scroll position isn't kept when statuses over the scrollTop was deleted then new status arrived
-> It needs to know which statuses are over the scrollTop
* New status indicator should be active when new statuses arrived while mouse moved recently
-> It needs a) update indicator in ScrollableList, or b) set scrollTop status while mouse moving
Yamagishi Kazutoshi [Sat, 9 Sep 2017 11:42:48 +0000 (20:42 +0900)]
Fix second report (regression from
3b81baaaaf51ff1c70fb1f865eef07fdb33a5950 ) (#4863)
Eugen Rochko [Sat, 9 Sep 2017 11:41:45 +0000 (13:41 +0200)]
Add missing reject_media check before avatar download via ActivityPub (#4862)
Lynx Kotoura [Sat, 9 Sep 2017 00:26:58 +0000 (09:26 +0900)]
Scrollable tables in settings pages (#4857)
* Scrollable tables in settings pages
* Add space before curly brace
Eugen Rochko [Sat, 9 Sep 2017 00:26:41 +0000 (02:26 +0200)]
Fix #1004 - Temporarily pause timeline if there's been recent mouse movement (#4859)
Eugen Rochko [Sat, 9 Sep 2017 00:02:44 +0000 (02:02 +0200)]
Fix #4852 - Check if already requested from FollowService (#4855)
Eugen Rochko [Sat, 9 Sep 2017 00:02:29 +0000 (02:02 +0200)]
Fix #4850 - When visibility missing from API call to toot, fallback to user preference (#4861)
unarist [Fri, 8 Sep 2017 19:43:34 +0000 (04:43 +0900)]
Refresh timeline after toot while the timeline is disconnected (#4858)
To reflect status posting immediately, we've inserted the status into timelines directly. However, status insertion changes "latest status", and it means next timeline refresh only fetches statuses since the inserted status. This behavior is very bad for disconnected timeline and mobile views.
After this patch, it refreshes timeline for disconnected timelines, instead of direct insertion.
unarist [Fri, 8 Sep 2017 16:20:03 +0000 (01:20 +0900)]
Handle stream_entry URL correctly in ActivityPub (#4854)
In before, the method uses stream_entry id as status id, so replied status was wrongly selected.
This PR uses StatusFinder which was introduced with `Api::Web::EmbedsController`.
Quent-in [Fri, 8 Sep 2017 11:55:47 +0000 (13:55 +0200)]
i10n update OC and FR (#4849)
* Missing "navigation_bar.pins"
* Missing "navigation_bar.pins"
Eugen Rochko [Fri, 8 Sep 2017 10:32:22 +0000 (12:32 +0200)]
Fix language filter codes (#4841)
* Fix language filter codes
CLD3 returns BCP-47 language identifier, filter settings expect
identifiers in the ISO 639-1 format. Convert between formats,
and exclude duplicate languages from filter choices (zh-CN->zh)
* Fix zh name
Eugen Rochko [Fri, 8 Sep 2017 10:00:30 +0000 (12:00 +0200)]
"Mute conversation" option on all own toots, not just in notifications (#4844)
That way you can mute notifications for a toot before you get replies
to it or boosts or favourites
Eugen Rochko [Fri, 8 Sep 2017 10:00:17 +0000 (12:00 +0200)]
Fetch statuses/following/followers numbers from ActivityPub collections (#4840)
m4sk1n [Thu, 7 Sep 2017 20:51:48 +0000 (22:51 +0200)]
i18n: Update Polish translation (#4845)
Signed-off-by: Marcin Mikołajczak <me@m4sk.in>
Quent-in [Thu, 7 Sep 2017 20:07:03 +0000 (22:07 +0200)]
i10n OC / FR update Pinned toots (#4842)
* Added column.pins
New strings
* Added column.pins
* Update confirmation_instructions.oc.html.erb
* Update confirmation_instructions.oc.text.erb
* Update password_change.oc.html.erb
* Update password_change.oc.text.erb
* Update reset_password_instructions.oc.html.erb
* Update reset_password_instructions.oc.text.erb
* Update confirmation_instructions.oc.html.erb
* Update confirmation_instructions.oc.text.erb
Eugen Rochko [Thu, 7 Sep 2017 18:18:34 +0000 (20:18 +0200)]
Fix #4834 - Adjust Status#local and Status#remote scopes (#4839)
abcang [Thu, 7 Sep 2017 14:44:15 +0000 (23:44 +0900)]
Enable UniqueRetryJobMiddleware even when called from sidekiq worker (#4836)
PFM [Thu, 7 Sep 2017 14:18:41 +0000 (23:18 +0900)]
Use <button> instead of <div role="button"> (#4835)
voidSatisfaction [Thu, 7 Sep 2017 07:58:11 +0000 (16:58 +0900)]
Add Pinned toot column (#4817)
* Add Pinned_toot_section
* Fix add frozen_string_literal
* Fix delete no need controller and tests
* Fix replace query strings to axios params
* Fix change value to accountId and disabling more button
voidSatisfaction [Thu, 7 Sep 2017 07:55:42 +0000 (16:55 +0900)]
Feat add validation for report comment: characters under 1000 valid (#4833)
Joseph Mingrone [Thu, 7 Sep 2017 01:55:06 +0000 (22:55 -0300)]
Use casecmp() instead of casecmp?() for now (#4832)
* Use casecmp() instead of casecmp?() for now
casecmp?() is only available in ruby 2.4.0. Users running earlier ruby versions
would see errors, e.g., running
RAILS_ENV=production rails mastodon:maintenance:remove_deprecated_preview_cards.
* Correctly check whether casecmp() returns 0
Quent-in [Wed, 6 Sep 2017 23:55:03 +0000 (01:55 +0200)]
i10n update OC and FR files (#4824)
* Onboarding: corrections
Some missing letters and spaces or better wording
* Embed
Translated as Intégrer in FR / Embarcar in OC
Olivier Humbert [Wed, 6 Sep 2017 20:32:49 +0000 (22:32 +0200)]
Update fr.json (#4830)
typo
Eugen Rochko [Wed, 6 Sep 2017 18:57:52 +0000 (20:57 +0200)]
Fix locking migration on statuses table. Nullable column and NO default value (#4825)
Eugen Rochko [Wed, 6 Sep 2017 17:02:03 +0000 (19:02 +0200)]
Bump version to 1.6.0rc2
Eugen Rochko [Wed, 6 Sep 2017 17:01:28 +0000 (19:01 +0200)]
Switch to static URIs, new URI format in both protocols for new statuses (#4815)
* Decouple Status#local? from uri being nil
* Replace on-the-fly URI generation with stored URIs
- Generate URI in after_save hook for local statuses
- Use static value in TagManager when available, fallback to tag format
- Make TagManager use ActivityPub::TagManager to understand new format
- Adjust tests
* Use other heuristic for locality of old statuses, do not perform long query
* Exclude tombstone stream entries from Atom feed
* Prevent nil statuses from landing in Pubsubhubbub::DistributionWorker
* Fix URI not being saved (#4818)
* Add more specs for Status
* Save generated uri immediately
and also fix method order to minimize diff.
* Fix alternate HTML URL in Atom
* Fix tests
* Remove not-null constraint from statuses migration to speed it up
voidSatisfaction [Wed, 6 Sep 2017 15:32:15 +0000 (00:32 +0900)]
Add Smartphone screen favourite back button and adjust styles (#4813)
* Feat add get-back button on favourite columnHeader
* Style adjust nice looking get-back button
* Fix delete media query and add padding right
* fix: restore padding and add lastchild style for back-button
Masoud Abkenar [Wed, 6 Sep 2017 15:31:54 +0000 (17:31 +0200)]
i18n: update Persian translation (#4822)
Clworld [Wed, 6 Sep 2017 15:29:56 +0000 (00:29 +0900)]
fix scroll position (#4821)
Yamagishi Kazutoshi [Wed, 6 Sep 2017 14:25:19 +0000 (23:25 +0900)]
Update react-intl to version 2.4.0 (#4820)
PFM [Wed, 6 Sep 2017 11:55:47 +0000 (20:55 +0900)]
fix text position of NSFW for video file (#4819)
Yamagishi Kazutoshi [Wed, 6 Sep 2017 10:13:00 +0000 (19:13 +0900)]
Add environment sample for OpenStack Swift (#4816)
Adam Thurlow [Tue, 5 Sep 2017 21:17:06 +0000 (18:17 -0300)]
swift-enable the paperclip! :paperclip: (#2322)
abcang [Tue, 5 Sep 2017 18:56:20 +0000 (03:56 +0900)]
Do not execute the job with the same arguments as the retry job (#4814)
Eugen Rochko [Tue, 5 Sep 2017 18:55:25 +0000 (20:55 +0200)]
Fix mentions in direct statuses not being delivered via AP (#4806)
Eugen Rochko [Tue, 5 Sep 2017 15:48:13 +0000 (17:48 +0200)]
Fix #4794 - Fake instant follow in API response when account is believed unlocked (#4799)
Lynx Kotoura [Tue, 5 Sep 2017 10:31:24 +0000 (19:31 +0900)]
Adjust status embeds (#4808)
* Adjust status embeds
Adjust styles of embed code. Adjust styles of embed pages. Fix overflow of embed-modal.
* Remove trailing whitespace
* Using width from the variable
takayamaki [Tue, 5 Sep 2017 10:30:01 +0000 (19:30 +0900)]
add index_notifications_on_id_and_account_id_and_activity_type on notifications table (#4750)
Treyssat-Vincent Nino [Tue, 5 Sep 2017 10:13:25 +0000 (12:13 +0200)]
comment correction (#4812)
voidSatisfaction [Mon, 4 Sep 2017 18:40:02 +0000 (03:40 +0900)]
Translation korean added (#4802)
ButterflyOfFire [Mon, 4 Sep 2017 17:54:12 +0000 (18:54 +0100)]
Update ar.yml (#4810)
Some little changes to "ar" locale
Eugen Rochko [Mon, 4 Sep 2017 16:26:33 +0000 (18:26 +0200)]
Fix some ActivityPub JSON bugs (#4796)
- Fix assumption that `url` is always a string. Handle it if it's an
array of strings, array of objects, object, or string, both for
accounts and for objects
- `sharedInbox` is actually supposed to be under `endpoints`, handle
both cases and adjust the serializer
nullkal [Mon, 4 Sep 2017 10:53:18 +0000 (19:53 +0900)]
Show pinned statuses only in the top of the profile page (#4803)
* Show pinned statuses only in the top of the profile page
* Refactor AccountsController#show_pinned_statuses?
voidSatisfaction [Mon, 4 Sep 2017 10:52:06 +0000 (19:52 +0900)]
Fix streaming url to lowercase (#4804)
Eugen Rochko [Mon, 4 Sep 2017 00:14:12 +0000 (02:14 +0200)]
Fix #4551 - Use correct syntax for content preloading (#4798)
abcang [Sun, 3 Sep 2017 18:31:51 +0000 (03:31 +0900)]
Fix a problem that notification column goes to top (#4792)
Eugen Rochko [Sun, 3 Sep 2017 13:17:34 +0000 (15:17 +0200)]
Fix short number locales (#4790)
Overwrite values from rails-i18n by manually overwriting in every locale.
We want numbers like 1.5K in every language
Andreas Drop [Sun, 3 Sep 2017 13:17:24 +0000 (15:17 +0200)]
Make german translation more gender neutral #4755 (#4789)
Akihiko Odaki [Sun, 3 Sep 2017 10:39:39 +0000 (19:39 +0900)]
Use next instead of return in task (#4787)
May Kittens Devour Your Soul [Sun, 3 Sep 2017 09:10:53 +0000 (11:10 +0200)]
Croatian translation - updated (#4183)
* Update hr.json
* Update hr.json
Quent-in [Sun, 3 Sep 2017 09:08:37 +0000 (11:08 +0200)]
l10n Occitan update for Embed, cancel follow request, ... (#4788)
* Update: some missing strings
* Updates missing strings
* New string
* Update oc.json
* Update oc.yml
* Update oc.json
Akihiko Odaki [Sun, 3 Sep 2017 05:58:58 +0000 (14:58 +0900)]
Explicitly define attached file of DeprecatedPreviewCard (#4786)
The path template of the attached files must explicitly be defined because
it is contradicting to the name of the class.
Eugen Rochko [Sat, 2 Sep 2017 23:12:05 +0000 (01:12 +0200)]
Bump version to 1.6.0rc1 (#4768)
Eugen Rochko [Sat, 2 Sep 2017 23:11:23 +0000 (01:11 +0200)]
Instantly upgrade account to ActivityPub if we receive ActivityPub payload (#4766)
Eugen Rochko [Sat, 2 Sep 2017 21:21:48 +0000 (23:21 +0200)]
Improve client-side German i18n (#4785)
Eugen Rochko [Sat, 2 Sep 2017 21:13:35 +0000 (23:13 +0200)]
Rename "locked" to "manuallyApprovesFollowers" in ActivityPub (#4779)
See: <https://www.w3.org/wiki/Activity_Streams_extensions#as:manuallyApprovesFollowers>
abcang [Sat, 2 Sep 2017 18:45:42 +0000 (03:45 +0900)]
Validate data of Imports (#4782)
m4sk1n [Sat, 2 Sep 2017 18:45:20 +0000 (20:45 +0200)]
i18n: Improve Polish translation (#4783)
Signed-off-by: Marcin Mikołajczak <me@m4sk.in>
Eugen Rochko [Sat, 2 Sep 2017 18:44:41 +0000 (20:44 +0200)]
Make "unfollow" undo pending outgoing follow request too (#4781)
* Make "unfollow" undo pending outgoing follow request too
* Add cancel button to web UI when awaiting follow request approval
* Make the hourglass button do the cancelling
PFM [Sat, 2 Sep 2017 16:52:56 +0000 (01:52 +0900)]
fix text position of NSFW in Safari (Mac/iPhone) (#4570)
unarist [Sat, 2 Sep 2017 15:42:47 +0000 (00:42 +0900)]
Raise an error for remote url in StatusFinder (#4776)
* Raise an error for remote url in StatusFinder
Previous implementation had allowed remote url with status id which also exists on local.
Then that bug leads /api/web/embed to return wrong embed url.
* Fix oembed_controller_spec
unarist [Sat, 2 Sep 2017 14:50:42 +0000 (23:50 +0900)]
Fix WebPush (regression from #4524) (#4778)
* Fix NoMethodError in Web::PushSubscription
```
undefined method `site_contact_email' for #<Class:0x00005976d13c40>
/usr/local/bundle/gems/activerecord-5.1.3/lib/active_record/dynamic_matchers.rb:22:in `method_missing'
/usr/local/bundle/gems/attr_encrypted-3.0.3/lib/attr_encrypted.rb:295:in `method_missing'
/usr/local/bundle/gems/attr_encrypted-3.0.3/lib/attr_encrypted/adapters/active_record.rb:129:in `method_missing_with_attr_encrypted'
/mastodon/app/models/web/push_subscription.rb:53:in `push_payload'
```
* Specify serializer in Web::NotificationSerializer
Surinna Curtis [Sat, 2 Sep 2017 14:27:16 +0000 (09:27 -0500)]
Don't unconditionally call `preventDefault` and `stopPropagation` on all keyup events (#4777)
* UploadArea should only preventDefault for Escape
This will make accessibility for some things less effortful, since we won't have to define a prior event handler to do whatever should be happening by default.
* Remove workaround for fixed bug in SettingToggle
SettingToggle was toggling itself in response to keydown of space, and then the keyup was doing it again
m4sk1n [Sat, 2 Sep 2017 14:25:54 +0000 (16:25 +0200)]
i18n: Update Polish translation (#4775)
Signed-off-by: Marcin Mikołajczak <me@m4sk.in>
Lynx Kotoura [Sat, 2 Sep 2017 13:49:28 +0000 (22:49 +0900)]
Adjust settings pages (#4765)
* views: Adjust heading positions
* Adjust settings pages
Adjust label. Adjust tables. Adjust admin/reports/* pages. Fix 2FA QR code style for narrow devices. Widen several pages. Increase contrast.
* Remove trailing whitespace
Yamagishi Kazutoshi [Sat, 2 Sep 2017 12:02:29 +0000 (21:02 +0900)]
Add Japanese translate for #4561 (#4771)
Yamagishi Kazutoshi [Sat, 2 Sep 2017 12:02:15 +0000 (21:02 +0900)]
Add text color style for noscript link (#4772)
Yamagishi Kazutoshi [Sat, 2 Sep 2017 12:01:59 +0000 (21:01 +0900)]
Fix profile page when use system's font (#4774)
Yamagishi Kazutoshi [Sat, 2 Sep 2017 12:01:44 +0000 (21:01 +0900)]
Disable embed modal when private status (#4773)
* Disable embed modal when private status
* Remove `reblogDisabled`
Eugen Rochko [Sat, 2 Sep 2017 12:01:23 +0000 (14:01 +0200)]
Define missing JSON-LD properties (#4767)
Using _: property names is discouraged, as in the future,
canonicalization may throw an error when encountering that instead
of discarding it silently like it does now.
We are defining some ActivityStreams properties which we expect
to land in ActivityStreams eventually, to ensure that future versions
of Mastodon will remain compatible with this even once that happens.
Those would be `locked`, `sensitive` and `Hashtag`
We are defining a custom context inline for some properties which we
do not expect to land in any other context. `atomUri`, `inReplyToAtomUri`
and `conversation` are part of the custom defined OStatus context.
Eugen Rochko [Sat, 2 Sep 2017 12:00:58 +0000 (14:00 +0200)]
Use updated ActivityStreams context (added: sharedInbox) (#4764)
mayaeh [Sat, 2 Sep 2017 05:48:51 +0000 (14:48 +0900)]
Add japanese translations for embed modal feature. (#4770)
Yamagishi Kazutoshi [Sat, 2 Sep 2017 01:03:21 +0000 (10:03 +0900)]
Add RoutingHelper (#4769)
m4sk1n [Fri, 1 Sep 2017 23:52:28 +0000 (01:52 +0200)]
Add link to 'noscript' message (#4561)
* Add link to 'noscript' message
Signed-off-by: Marcin Mikołajczak <me@m4sk.in>
* remove indent
Eugen Rochko [Fri, 1 Sep 2017 19:54:42 +0000 (21:54 +0200)]
Add ActivityPub handler for Delete->Actor activities (#4761)
Eugen Rochko [Fri, 1 Sep 2017 19:30:13 +0000 (21:30 +0200)]
Finish up embed modal feature (#4759)
* Add embed button to dropdowns of in-timeline statuses
* yarn run manage:translations
Eugen Rochko [Fri, 1 Sep 2017 19:26:01 +0000 (21:26 +0200)]
Avoid sending some ActivityPub payloads if the receiver will get them through distribution (#4739)
Eugen Rochko [Fri, 1 Sep 2017 19:12:59 +0000 (21:12 +0200)]
Do not rely on activity arriving exactly once after delete arrived (#4754)
Cygnan [Fri, 1 Sep 2017 19:01:23 +0000 (04:01 +0900)]
Adjust padding on the public profile page (#4757)
* Fix a style issue on the public profile page for some mobile browsers
Signed-off-by: Cygnan <email@cygnan.com>
* Set padding-bottom to 20px
Signed-off-by: Cygnan <email@cygnan.com>
unarist [Fri, 1 Sep 2017 19:00:43 +0000 (04:00 +0900)]
Deduplicate with local status on Create activity (#4763)
Eugen Rochko [Fri, 1 Sep 2017 18:50:42 +0000 (20:50 +0200)]
Fix NoMethodError (#4762)
Eugen Rochko [Fri, 1 Sep 2017 14:20:16 +0000 (16:20 +0200)]
Make PreviewCard records reuseable between statuses (#4642)
* Make PreviewCard records reuseable between statuses
**Warning!** Migration truncates preview_cards tablec
* Allow a wider thumbnail for link preview, display it in horizontal layout (#4648)
* Delete preview cards files before truncating
* Rename old table instead of truncating it
* Add mastodon:maintenance:remove_deprecated_preview_cards
* Ignore deprecated_preview_cards in schema definition
* Fix null behaviour
Yamagishi Kazutoshi [Fri, 1 Sep 2017 14:13:31 +0000 (23:13 +0900)]
Use system's default font on non web UI pages (#4553)
* Use system's default font on non web UI pages
* Remove import for Redirect
Eugen Rochko [Fri, 1 Sep 2017 14:07:08 +0000 (16:07 +0200)]
Make first use less overwhelming with browser permissions (#4760)
- Ask for desktop notifications after 1 minute of use instead of
instantly
- Ask for protocol handler permission after 5 minutes of use
instead of instantly
Damien Erambert [Fri, 1 Sep 2017 12:09:01 +0000 (05:09 -0700)]
Update FR locales (#4714)
* Make the fr locales up-to-date with the last changes (new profile view, applications)
* Use the same wording for toots in fr.yml and fr.json
* Translate the pin related strings
* Translate pin-related locales on the front-end
* Add missing locales in doorkeeper.fr.yml and remove un-used ones
* Change "posts" back to "status" in the /about/more page in fr.yml
* Fix typos for "status" in fr.yml
* fix typo for "status" in fr.json
* Remove duplicate string
* Non-breaking space before punctuation
* 'Better' translation for "unpin"
* Put back 'pouet' where it was already
* Fix
* Fix
Eugen Rochko [Fri, 1 Sep 2017 11:35:23 +0000 (13:35 +0200)]
Refactor Web::PushSubscription, remove welcome message (#4524)
* Refactor Web::PushSubscription, remove welcome message
* Add missing helper
* Use locale of the receiver on push notifications (#4519)
* Remove unused translations
* Fix dir on notifications
unarist [Fri, 1 Sep 2017 11:34:04 +0000 (20:34 +0900)]
Convert OStatus tag to ActivityPub id on in_reply_to resolution (#4756)
unarist [Fri, 1 Sep 2017 10:33:02 +0000 (19:33 +0900)]
Fallback from perform_via_activitypub on private posts (#4758)
Currently, private / direct posts via OStatus from AP compatible instance will be dropped due to failing to fetch AP version.
So this fallbacks to OStatus handling:
* when failed to fetch ActivityPub version
* when status is neither :public nor :unlisted
Eugen Rochko [Thu, 31 Aug 2017 19:32:09 +0000 (21:32 +0200)]
Remove identity context from output of LinkedDataSignature (#4753)
unarist [Thu, 31 Aug 2017 15:18:49 +0000 (00:18 +0900)]
Don't process ActivityPub payload if signature is invalid (#4752)
* Don't process ActivityPub payload if signature is invalid
* Fix style issue
James [Thu, 31 Aug 2017 13:44:00 +0000 (06:44 -0700)]
Guarantee Subscription service first account has proper URL details (#4732)
* Guarantee Subscription service first account has proper URL details
Subscription Service potentially could break if the first user suspended
themselves, creating a situation where the urls that populate throughout
subscription service's PuSH request would cause the remote API to throw 503 errors.
Guaranteeing that the first account picked is not suspended prevents this problem.
* Fix style issue
Akihiko Odaki [Thu, 31 Aug 2017 09:20:54 +0000 (18:20 +0900)]
Fix the usages of Detect Passive Events (#4749)
Eugen Rochko [Thu, 31 Aug 2017 01:38:35 +0000 (03:38 +0200)]
Embed modal (#4748)
* Embed modal
* Proxy OEmbed requests from web UI
Eugen Rochko [Wed, 30 Aug 2017 22:02:59 +0000 (00:02 +0200)]
Add sharedInbox to actors (#4737)
Wonderfall [Wed, 30 Aug 2017 21:52:19 +0000 (23:52 +0200)]
Update to Alpine 3.6 (#4747)
MitarashiDango [Wed, 30 Aug 2017 15:30:25 +0000 (00:30 +0900)]
error fixed (when loading pages in single column mode.) (#4746)
Eugen Rochko [Wed, 30 Aug 2017 13:37:02 +0000 (15:37 +0200)]
Forward ActivityPub creates that reply to local statuses (#4709)
* Forward ActivityPub creates that reply to local statuses
* Fix test
* Fix wrong signers