From: ThibG <thib@sitedethib.com>
Date: Thu, 18 Jul 2019 23:44:58 +0000 (+0200)
Subject: Fix sanitizing lists contents (#11354)
X-Git-Url: https://git.xn--scling-oua.cat.family/?a=commitdiff_plain;h=fda437a02088ac114fecb69e3b1e52f495a2dd9a;p=mastodon.git

Fix sanitizing lists contents (#11354)

* Add test

* Fix code for sanitizing nested lists stripping all tags
---

diff --git a/app/lib/sanitize_config.rb b/app/lib/sanitize_config.rb
index e82a2a33a..aba8ce9f6 100644
--- a/app/lib/sanitize_config.rb
+++ b/app/lib/sanitize_config.rb
@@ -25,6 +25,8 @@ class Sanitize
       case env[:node_name]
       when 'li'
         env[:node].traverse do |node|
+          next unless %w(p ul ol li).include?(node.name)
+
           node.add_next_sibling('<br>') if node.next_sibling
           node.replace(node.children) unless node.text?
         end
diff --git a/spec/lib/sanitize_config_spec.rb b/spec/lib/sanitize_config_spec.rb
index bb3cf6f0b..54bd8693c 100644
--- a/spec/lib/sanitize_config_spec.rb
+++ b/spec/lib/sanitize_config_spec.rb
@@ -22,5 +22,9 @@ describe Sanitize::Config do
     it 'converts ul inside ul' do
       expect(Sanitize.fragment('<ul><li>Foo</li><li><ul><li>Bar</li><li>Baz</li></ul></li></ul>', subject)).to eq '<p>Foo<br>Bar<br>Baz</p>'
     end
+
+    it 'keep links in lists' do
+      expect(Sanitize.fragment('<p>Check out:</p><ul><li><a href="https://joinmastodon.org" rel="nofollow noopener" target="_blank">joinmastodon.org</a></li><li>Bar</li></ul>', subject)).to eq '<p>Check out:</p><p><a href="https://joinmastodon.org" rel="nofollow noopener" target="_blank">joinmastodon.org</a><br>Bar</p>'
+    end
   end
 end