From: Thibaut Girka <thib@sitedethib.com>
Date: Thu, 23 May 2019 16:53:24 +0000 (+0200)
Subject: Do not share a single Redcarpet::Markdown object across threads
X-Git-Url: https://git.xn--scling-oua.cat.family/?a=commitdiff_plain;h=d6a7d62dc698d6ebaa3a40f44c20ef12f8474fd7;p=mastodon.git

Do not share a single Redcarpet::Markdown object across threads

There are apparently thread-safety issues: https://github.com/vmg/redcarpet/pull/672
---

diff --git a/app/lib/formatter.rb b/app/lib/formatter.rb
index a099ff728..8a2828bbf 100644
--- a/app/lib/formatter.rb
+++ b/app/lib/formatter.rb
@@ -137,8 +137,6 @@ class Formatter
   private
 
   def markdown_formatter
-    return @markdown_formatter if defined?(@markdown_formatter)
-
     extensions = {
       autolink: true,
       no_intra_emphasis: true,
@@ -163,7 +161,7 @@ class Formatter
       link_attributes: { target: '_blank', rel: 'nofollow noopener' },
     })
 
-    @markdown_formatter = Redcarpet::Markdown.new(renderer, extensions)
+    Redcarpet::Markdown.new(renderer, extensions)
   end
 
   def html_entities