From: ThibG <thib@sitedethib.com>
Date: Wed, 27 Feb 2019 13:57:14 +0000 (+0100)
Subject: Fix mention processing for unknwon accounts on incoming ActivityPub Notes (#10125)
X-Git-Url: https://git.xn--scling-oua.cat.family/?a=commitdiff_plain;h=9edab463682f5d5beb0a7f4e4574d708c95bbc52;p=mastodon.git

Fix mention processing for unknwon accounts on incoming ActivityPub Notes (#10125)

`::FetchRemoteAccountService` is not `ActivityPub::FetchRemoteAccountService`,
its second argument is the pre-fetched body. Passing `id: false` actually passed
a `Hash` as the prefetched body, instead of properly resolving unknown remote
accounts.
---

diff --git a/app/lib/activitypub/activity/create.rb b/app/lib/activitypub/activity/create.rb
index d7bd65c80..6d58aba70 100644
--- a/app/lib/activitypub/activity/create.rb
+++ b/app/lib/activitypub/activity/create.rb
@@ -159,7 +159,7 @@ class ActivityPub::Activity::Create < ActivityPub::Activity
     return if tag['href'].blank?
 
     account = account_from_uri(tag['href'])
-    account = ::FetchRemoteAccountService.new.call(tag['href'], id: false) if account.nil?
+    account = ::FetchRemoteAccountService.new.call(tag['href']) if account.nil?
 
     return if account.nil?