From: Keiji, Yoshimi <walf443@gmail.com>
Date: Mon, 17 Apr 2017 02:23:13 +0000 (+0900)
Subject: reduce unneed query when post without attachements. (#1907)
X-Git-Url: https://git.xn--scling-oua.cat.family/?a=commitdiff_plain;h=7a5086729affa01f44eda3ad72da147abb4377c5;p=mastodon.git

reduce unneed query when post without attachements. (#1907)

* reduce unneed query when post without attachements.

This commit reduce following query:

```
 MediaAttachment Load (0.9ms)  SELECT "media_attachments".* FROM "media_attachments" WHERE "media_attachments"."status
_id" IS NULL AND 1=0 ORDER BY id asc
```

* fixed for more simple changes.
---

diff --git a/app/services/post_status_service.rb b/app/services/post_status_service.rb
index ec2b90e07..00af28edd 100644
--- a/app/services/post_status_service.rb
+++ b/app/services/post_status_service.rb
@@ -36,7 +36,7 @@ class PostStatusService < BaseService
   private
 
   def validate_media!(media_ids)
-    return if media_ids.nil? || !media_ids.is_a?(Enumerable)
+    return if media_ids.blank? || !media_ids.is_a?(Enumerable)
 
     raise Mastodon::ValidationError, I18n.t('media_attachments.validations.too_many') if media_ids.size > 4