From: Eugen Rochko <eugen@zeonfederated.com>
Date: Sun, 6 Oct 2019 04:20:57 +0000 (+0200)
Subject: Fix S3 adapter retrying failing uploads with exponential backoff (#12085)
X-Git-Url: https://git.xn--scling-oua.cat.family/?a=commitdiff_plain;h=086fc7ed7733c7ec3b51a2513d496670f6a97219;p=mastodon.git

Fix S3 adapter retrying failing uploads with exponential backoff (#12085)

The default limit of 10 retries with exponential backoff meant
that if the S3 server was timing out, you would be stuck with it
for much, much longer than the 5 second read timeout we expect.

The uploading happens within a database transaction, which means
a failing S3 server could negatively affect database performance
---

diff --git a/config/initializers/paperclip.rb b/config/initializers/paperclip.rb
index f308c2841..a0253f4bc 100644
--- a/config/initializers/paperclip.rb
+++ b/config/initializers/paperclip.rb
@@ -40,6 +40,7 @@ if ENV['S3_ENABLED'] == 'true'
       http_open_timeout: 5,
       http_read_timeout: 5,
       http_idle_timeout: 5,
+      retry_limit: 0,
     }
   )