]> cat aescling's git repositories - mastodon.git/commitdiff
cache blockings for reducing queries.
authorKeiji Yoshimi <walf443@gmail.com>
Sat, 15 Apr 2017 14:59:39 +0000 (23:59 +0900)
committerKeiji Yoshimi <walf443@gmail.com>
Sun, 16 Apr 2017 03:20:38 +0000 (12:20 +0900)
app/models/block.rb
app/models/mute.rb
app/models/status.rb

index ae456a6b6bf798cc2201ef700cff60837f91fd1a..ac1e1b0b1b36a083cd890fe56e32c97eca8f2778 100644 (file)
@@ -7,4 +7,12 @@ class Block < ApplicationRecord
   belongs_to :target_account, class_name: 'Account', required: true
 
   validates :account_id, uniqueness: { scope: :target_account_id }
+
+  after_create :remove_blocking_cache
+  after_destroy :remove_blocking_cache
+
+  def remove_blocking_cache
+    Rails.cache.delete("blocked_account_ids:#{account_id}")
+    Rails.cache.delete("blocked_account_ids:#{target_account_id}")
+  end
 end
index a5b334c859eaffceb93790a6cba451949a422fdb..875d030e97a81fa1d9f798b150886c952e1f896d 100644 (file)
@@ -8,4 +8,11 @@ class Mute < ApplicationRecord
 
   validates :account, :target_account, presence: true
   validates :account_id, uniqueness: { scope: :target_account_id }
+
+  after_create :remove_blocking_cache
+  after_destroy :remove_blocking_cache
+
+  def remove_blocking_cache
+    Rails.cache.delete("blocked_account_ids:#{account_id}")
+  end
 end
index 16cd4383f15d33f3c3a0a9a252b44ca048704c87..22d93947a937e0a5c88709c45d4bc01c3bd3f6e3 100644 (file)
@@ -180,7 +180,9 @@ class Status < ApplicationRecord
     private
 
     def filter_timeline(query, account)
-      blocked = Block.where(account: account).pluck(:target_account_id) + Block.where(target_account: account).pluck(:account_id) + Mute.where(account: account).pluck(:target_account_id)
+      blocked = Rails.cache.fetch("blocked_account_ids:#{account.id}") do
+        Block.where(account: account).pluck(:target_account_id) + Block.where(target_account: account).pluck(:account_id) + Mute.where(account: account).pluck(:target_account_id)
+      end
       query   = query.where('statuses.account_id NOT IN (?)', blocked) unless blocked.empty?  # Only give us statuses from people we haven't blocked, or muted, or that have blocked us
       query   = query.where('accounts.silenced = TRUE') if account.silenced?                  # and if we're hellbanned, only people who are also hellbanned
       query