]> cat aescling's git repositories - mastodon.git/commitdiff
Clone response before put it to the cache (#6932)
authorunarist <m.unarist@gmail.com>
Tue, 27 Mar 2018 13:18:35 +0000 (22:18 +0900)
committerEugen Rochko <eugen@zeonfederated.com>
Tue, 27 Mar 2018 13:18:35 +0000 (15:18 +0200)
`Response.prototype.clone()` must be called before the response used.

This fixes an error from ServiceWorker and failing to load image when the
image is not cached.

app/javascript/mastodon/service_worker/entry.js

index b9cf06ef986305a9985a32b21f1d436bdb64c957..160c3fbf25772b48c98838d52ef58b8801763dc5 100644 (file)
@@ -56,10 +56,10 @@ self.addEventListener('fetch', function(event) {
         const fetched = await fetch(event.request);
 
         if (fetched.ok) {
-          await cache.put(event.request.url, fetched);
+          await cache.put(event.request.url, fetched.clone());
         }
 
-        return fetched.clone();
+        return fetched;
       }
 
       return cached;