Rename cache key to exclude_account_ids_for:id, adjust formatting

diff --git a/app/models/block.rb b/app/models/block.rb
index ac1e1b0b1b36a083cd890fe56e32c97eca8f2778..c978b2200a134fd930dd4155e6e0a30225b07134 100644 (file)
--- a/app/models/block.rb
+++ b/app/models/block.rb
@@ -8,11 +8,13 @@ class Block < ApplicationRecord
 
   validates :account_id, uniqueness: { scope: :target_account_id }
 
-  after_create :remove_blocking_cache
+  after_create  :remove_blocking_cache
   after_destroy :remove_blocking_cache
 
+  private
+
   def remove_blocking_cache
-    Rails.cache.delete("blocked_account_ids:#{account_id}")
-    Rails.cache.delete("blocked_account_ids:#{target_account_id}")
+    Rails.cache.delete("exclude_account_ids_for:#{account_id}")
+    Rails.cache.delete("exclude_account_ids_for:#{target_account_id}")
   end
 end

diff --git a/app/models/mute.rb b/app/models/mute.rb
index 0cf17be4f99faeaf30d65a80d805998361126ffd..d0de62ed5d089a8518e9adf3e73c9a553c0986cc 100644 (file)
--- a/app/models/mute.rb
+++ b/app/models/mute.rb
@@ -8,10 +8,12 @@ class Mute < ApplicationRecord
 
   validates :account_id, uniqueness: { scope: :target_account_id }
 
-  after_create :remove_blocking_cache
+  after_create  :remove_blocking_cache
   after_destroy :remove_blocking_cache
 
+  private
+
   def remove_blocking_cache
-    Rails.cache.delete("blocked_account_ids:#{account_id}")
+    Rails.cache.delete("exclude_account_ids_for:#{account_id}")
   end
 end

diff --git a/app/models/status.rb b/app/models/status.rb
index c05a3386f30b4c2ee98ab7afc94f2a080660b145..a9b7327c359934137a977a9150bbbeea28c5b64f 100644 (file)
--- a/app/models/status.rb
+++ b/app/models/status.rb
@@ -183,9 +183,7 @@ class Status < ApplicationRecord
     private
 
     def filter_timeline(query, account)
-      blocked = Rails.cache.fetch("blocked_account_ids:#{account.id}") do
-        Block.where(account: account).pluck(:target_account_id) + Block.where(target_account: account).pluck(:account_id) + Mute.where(account: account).pluck(:target_account_id)
-      end
+      blocked = Rails.cache.fetch("exclude_account_ids_for:#{account.id}") { Block.where(account: account).pluck(:target_account_id) + Block.where(target_account: account).pluck(:account_id) + Mute.where(account: account).pluck(:target_account_id) }
       query   = query.where('statuses.account_id NOT IN (?)', blocked) unless blocked.empty?  # Only give us statuses from people we haven't blocked, or muted, or that have blocked us
       query   = query.where('accounts.silenced = TRUE') if account.silenced?                  # and if we're hellbanned, only people who are also hellbanned
       query