Add filters for suspended accounts

diff --git a/app/controllers/accounts_controller.rb b/app/controllers/accounts_controller.rb
index 46231dd9714c8cb38ec2e1e4441ec8db8d2f7eeb..57f25a2736f5a871ef2ddb9f990ae23110e12a5c 100644 (file)
--- a/app/controllers/accounts_controller.rb
+++ b/app/controllers/accounts_controller.rb
@@ -5,6 +5,8 @@ class AccountsController < ApplicationController
 
   before_action :set_account
   before_action :set_link_headers
+  before_action :authenticate_user!, only: [:follow, :unfollow]
+  before_action :check_account_suspension
 
   def show
     respond_to do |format|
@@ -50,4 +52,8 @@ class AccountsController < ApplicationController
   def webfinger_account_url
     webfinger_url(resource: "acct:#{@account.acct}@#{Rails.configuration.x.local_domain}")
   end
+
+  def check_account_suspension
+    head 410 if @account.suspended?
+  end
 end

diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb
index 7270686de4bdc3eb549a842d1956785043607358..e2d879d58876ad55c5a8aaf3da836b13585dc0f5 100644 (file)
--- a/app/controllers/application_controller.rb
+++ b/app/controllers/application_controller.rb
@@ -15,6 +15,7 @@ class ApplicationController < ActionController::Base
   before_action :store_current_location, except: :raise_not_found, unless: :devise_controller?
   before_action :set_locale
   before_action :set_user_activity
+  before_action :check_suspension, if: :user_signed_in?
 
   def raise_not_found
     raise ActionController::RoutingError, "No route matches #{params[:unmatched_route]}"
@@ -40,6 +41,10 @@ class ApplicationController < ActionController::Base
     current_user.touch(:current_sign_in_at) if !current_user.nil? && (current_user.current_sign_in_at.nil? || current_user.current_sign_in_at < 24.hours.ago)
   end
 
+  def check_suspension
+    head 403 if current_user.account.suspended?
+  end
+
   protected
 
   def not_found

diff --git a/app/controllers/settings/preferences_controller.rb b/app/controllers/settings/preferences_controller.rb
index cacc03b65f0673b02bbb93269fbd9d1fcfd717a4..692cf95acea2225eb7557b512f5c5a4fee42bf73 100644 (file)
--- a/app/controllers/settings/preferences_controller.rb
+++ b/app/controllers/settings/preferences_controller.rb
@@ -5,8 +5,7 @@ class Settings::PreferencesController < ApplicationController
 
   before_action :authenticate_user!
 
-  def show
-  end
+  def show; end
 
   def update
     current_user.settings(:notification_emails).follow    = user_params[:notification_emails][:follow]    == '1'

diff --git a/app/controllers/settings/profiles_controller.rb b/app/controllers/settings/profiles_controller.rb
index 0276f5fed44f084d06bc942cf9317bcdfd9fa16f..9e8a7da8cf59b526cd37f0d8f6a4e785e35a242a 100644 (file)
--- a/app/controllers/settings/profiles_controller.rb
+++ b/app/controllers/settings/profiles_controller.rb
@@ -10,8 +10,7 @@ class Settings::ProfilesController < ApplicationController
   obfuscate_filename [:account, :avatar]
   obfuscate_filename [:account, :header]
 
-  def show
-  end
+  def show; end
 
   def update
     if @account.update(account_params)

diff --git a/app/controllers/stream_entries_controller.rb b/app/controllers/stream_entries_controller.rb
index caab1237d17c8def9d2a1414915798fa4a86ea15..98d029030521787efd7680ee34d1842cfad772d9 100644 (file)
--- a/app/controllers/stream_entries_controller.rb
+++ b/app/controllers/stream_entries_controller.rb
@@ -6,6 +6,7 @@ class StreamEntriesController < ApplicationController
   before_action :set_account
   before_action :set_stream_entry
   before_action :set_link_headers
+  before_action :check_account_suspension
 
   def show
     @type = @stream_entry.activity_type.downcase
@@ -37,4 +38,8 @@ class StreamEntriesController < ApplicationController
   def set_stream_entry
     @stream_entry = @account.stream_entries.find(params[:id])
   end
+
+  def check_account_suspension
+    head 410 if @account.suspended?
+  end
 end

diff --git a/app/services/follow_service.rb b/app/services/follow_service.rb
index 09fa295e36ecba3d3ed553ca79d7a33132a39ff1..423b833cfbd5c32fd695bd948e25b1883b1e5396 100644 (file)
--- a/app/services/follow_service.rb
+++ b/app/services/follow_service.rb
@@ -7,7 +7,7 @@ class FollowService < BaseService
   def call(source_account, uri)
     target_account = follow_remote_account_service.call(uri)
 
-    raise ActiveRecord::RecordNotFound if target_account.nil? || target_account.id == source_account.id
+    raise ActiveRecord::RecordNotFound if target_account.nil? || target_account.id == source_account.id || target_account.suspended?
 
     follow = source_account.follow!(target_account)
 

diff --git a/app/services/notify_service.rb b/app/services/notify_service.rb
index ab76e2a6be572d4a916ed1a1dd3410ca263cc21c..8263c43765eea697fc02f4a231365d116cdde3a1 100644 (file)
--- a/app/services/notify_service.rb
+++ b/app/services/notify_service.rb
@@ -33,13 +33,13 @@ class NotifyService < BaseService
   end
 
   def blocked?
-    blocked   = false
-    blocked ||= @recipient.id == @notification.from_account.id
-    blocked ||= @recipient.blocking?(@notification.from_account)
-    blocked ||= (@notification.from_account.silenced? && !@recipient.following?(@notification.from_account))
-    blocked ||= (@recipient.user.settings(:interactions).must_be_follower  && !@notification.from_account.following?(@recipient))
-    blocked ||= (@recipient.user.settings(:interactions).must_be_following && !@recipient.following?(@notification.from_account))
-    blocked ||= send("blocked_#{@notification.type}?")
+    blocked   = @recipient.suspended?                                                                                             # Skip if the recipient account is suspended anyway
+    blocked ||= @recipient.id == @notification.from_account.id                                                                    # Skip for interactions with self
+    blocked ||= @recipient.blocking?(@notification.from_account)                                                                  # Skip for blocked accounts
+    blocked ||= (@notification.from_account.silenced? && !@recipient.following?(@notification.from_account))                      # Hellban
+    blocked ||= (@recipient.user.settings(:interactions).must_be_follower  && !@notification.from_account.following?(@recipient)) # Options
+    blocked ||= (@recipient.user.settings(:interactions).must_be_following && !@recipient.following?(@notification.from_account)) # Options
+    blocked ||= send("blocked_#{@notification.type}?")                                                                            # Type-dependent filters
     blocked
   end
 

diff --git a/app/workers/admin/suspension_worker.rb b/app/workers/admin/suspension_worker.rb
new file mode 100644 (file)
index 0000000..38761f3
--- /dev/null
+++ b/app/workers/admin/suspension_worker.rb
@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+class Admin::SuspensionWorker
+  include Sidekiq::Worker
+
+  def perform(account_id)
+    SuspendAccountService.new.call(Account.find(account_id))
+  end
+end