Change default interface of web and streaming from 0.0.0.0 to 127.0.0.1 (#11302)

diff --git a/config/puma.rb b/config/puma.rb
index 1afdb1c6dfbc0900051690c33a2013482398132a..25a5534b29dcfbb34866dae13b1f88f4c16948cd 100644 (file)
--- a/config/puma.rb
+++ b/config/puma.rb
@@ -2,9 +2,9 @@ threads_count = ENV.fetch('MAX_THREADS') { 5 }.to_i
 threads threads_count, threads_count
 
 if ENV['SOCKET']
-  bind 'unix://' + ENV['SOCKET']
+  bind "unix://#{ENV['SOCKET']}"
 else
-  port ENV.fetch('PORT') { 3000 }
+  bind "tcp://127.0.0.1:#{ENV.fetch('PORT', 3000)}"
 end
 
 environment ENV.fetch('RAILS_ENV') { 'development' }

diff --git a/docker-compose.yml b/docker-compose.yml
index 93d47f1a0102702e108cf39c00f27f6b77d97ad4..f3fe6cfd0b7e8f725be16c8034bbcc65497a9165 100644 (file)
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -58,7 +58,7 @@ services:
     image: tootsuite/mastodon
     restart: always
     env_file: .env.production
-    command: yarn start
+    command: BIND=0.0.0.0 node ./streaming
     networks:
       - external_network
       - internal_network

diff --git a/streaming/index.js b/streaming/index.js
index 639867b28c691148d25a3f30e4f06ca1e9ce7aa8..0529804b1b58fe94100f6e04e2aa8e16813176dd 100644 (file)
--- a/streaming/index.js
+++ b/streaming/index.js
@@ -672,7 +672,7 @@ const attachServerWithConfig = (server, onSuccess) => {
       }
     });
   } else {
-    server.listen(+process.env.PORT || 4000, process.env.BIND || '0.0.0.0', () => {
+    server.listen(+process.env.PORT || 4000, process.env.BIND || '127.0.0.1', () => {
       if (onSuccess) {
         onSuccess(`${server.address().address}:${server.address().port}`);
       }