Fix compatibility with PeerTube (#6968)

* Support fetching objects of convertible types by URL (fixes #6924)

* Ignore invalid hashtags

diff --git a/app/lib/activitypub/activity/create.rb b/app/lib/activitypub/activity/create.rb
index afee8a268a3b57fbb4a796cb43ce7552d0ece3d1..45c0e91cb08d08f69b1da3070c9eaaadb0b62522 100644 (file)
--- a/app/lib/activitypub/activity/create.rb
+++ b/app/lib/activitypub/activity/create.rb
@@ -79,6 +79,8 @@ class ActivityPub::Activity::Create < ActivityPub::Activity
     hashtag = Tag.where(name: hashtag).first_or_initialize(name: hashtag)
 
     status.tags << hashtag
+  rescue ActiveRecord::RecordInvalid
+    nil
   end
 
   def process_mention(tag, status)

diff --git a/app/services/fetch_atom_service.rb b/app/services/fetch_atom_service.rb
index 62dea8298a978ffc53c07fb9f7762f4165a66596..87076cc077111f9ec1085296f154f6aef1e5cf23 100644 (file)
--- a/app/services/fetch_atom_service.rb
+++ b/app/services/fetch_atom_service.rb
@@ -44,7 +44,7 @@ class FetchAtomService < BaseService
       json = body_to_json(body)
       if supported_context?(json) && json['type'] == 'Person' && json['inbox'].present?
         [json['id'], { prefetched_body: body, id: true }, :activitypub]
-      elsif supported_context?(json) && json['type'] == 'Note'
+      elsif supported_context?(json) && expected_type?(json)
         [json['id'], { prefetched_body: body, id: true }, :activitypub]
       else
         @unsupported_activity = true
@@ -61,6 +61,10 @@ class FetchAtomService < BaseService
     end
   end
 
+  def expected_type?(json)
+    (ActivityPub::Activity::Create::SUPPORTED_TYPES + ActivityPub::Activity::Create::CONVERTED_TYPES).include? json['type']
+  end
+
   def process_html(response)
     page = Nokogiri::HTML(response.body_with_limit)
 

diff --git a/app/services/resolve_url_service.rb b/app/services/resolve_url_service.rb
index 1f2b24524a77ee6a05a60da0de9d595195f64210..9499dc286e360abd4865693fa4539916caebd74a 100644 (file)
--- a/app/services/resolve_url_service.rb
+++ b/app/services/resolve_url_service.rb
@@ -19,7 +19,7 @@ class ResolveURLService < BaseService
     case type
     when 'Person'
       FetchRemoteAccountService.new.call(atom_url, body, protocol)
-    when 'Note'
+    when 'Note', 'Article', 'Image', 'Video'
       FetchRemoteStatusService.new.call(atom_url, body, protocol)
     end
   end