Don't create attachments if remote file cannot be fetched

diff --git a/app/models/media_attachment.rb b/app/models/media_attachment.rb
index d3e3d73beb83628dec6c5127ae9fa2777702f03d..bfbf00d762c51ff864ea22bf32bc6d06387be1bf 100644 (file)
--- a/app/models/media_attachment.rb
+++ b/app/models/media_attachment.rb
@@ -22,8 +22,6 @@ class MediaAttachment < ApplicationRecord
 
   def file_remote_url=(url)
     self.file = URI.parse(url)
-  rescue OpenURI::HTTPError => e
-    Rails.logger.debug "Error fetching remote attachment: #{e}"
   end
 
   def image?

diff --git a/app/services/process_feed_service.rb b/app/services/process_feed_service.rb
index 561feb0325bab74b107283990afaaf0441157264..08c66c9048f1b2d729321db61e4b7573c7575b68 100644 (file)
--- a/app/services/process_feed_service.rb
+++ b/app/services/process_feed_service.rb
@@ -173,7 +173,7 @@ class ProcessFeedService < BaseService
         begin
           media.file_remote_url = link['href']
           media.save
-        rescue Paperclip::Errors::NotIdentifiedByImageMagickError
+        rescue OpenURI::HTTPError, Paperclip::Errors::NotIdentifiedByImageMagickError
           next
         end
       end