]> cat aescling's git repositories - mastodon.git/commitdiff
Add alt attribute to ImageLoader (#3765)
authorYamagishi Kazutoshi <ykzts@desire.sh>
Thu, 15 Jun 2017 12:10:41 +0000 (21:10 +0900)
committerEugen Rochko <eugen@zeonfederated.com>
Thu, 15 Jun 2017 12:10:41 +0000 (14:10 +0200)
app/javascript/mastodon/features/ui/components/image_loader.js

index b357f28a0dfa92629b9148a8b2e5b3a1b4d3e470..a2514d6be6b064cb79a33661c9213acb176dc84f 100644 (file)
@@ -4,12 +4,17 @@ import PropTypes from 'prop-types';
 class ImageLoader extends React.PureComponent {
 
   static propTypes = {
+    alt: PropTypes.string,
     src: PropTypes.string.isRequired,
     previewSrc: PropTypes.string.isRequired,
     width: PropTypes.number.isRequired,
     height: PropTypes.number.isRequired,
   }
 
+  static defaultProps = {
+    alt: '',
+  };
+
   state = {
     loading: true,
     error: false,
@@ -35,12 +40,13 @@ class ImageLoader extends React.PureComponent {
   }
 
   render() {
-    const { src, previewSrc, width, height } = this.props;
+    const { alt, src, previewSrc, width, height } = this.props;
     const { loading, error } = this.state;
 
     return (
       <div className='image-loader'>
-        <img // eslint-disable-line jsx-a11y/img-has-alt
+        <img
+          alt={alt}
           className='image-loader__img'
           src={src}
           width={width}
@@ -48,7 +54,8 @@ class ImageLoader extends React.PureComponent {
         />
 
         {loading &&
-          <img // eslint-disable-line jsx-a11y/img-has-alt
+          <img
+            alt=''
             src={previewSrc}
             className='image-loader__preview-img'
           />