]> cat aescling's git repositories - mastodon.git/commitdiff
Fix “Change subscribed languages” crashing in some situations (#19268)
authorClaire <claire.github-309c@sitedethib.com>
Mon, 3 Oct 2022 00:56:12 +0000 (02:56 +0200)
committeraescling <aescling+gitlab@cat.family>
Thu, 17 Nov 2022 05:28:23 +0000 (00:28 -0500)
app/javascript/mastodon/features/subscribed_languages_modal/index.js

index 6a1bb2c47f404cc69a1426fb36e0cd2346fbdf86..a519ceabc5ad9de18ecafa1a60c3b2e0126efdae 100644 (file)
@@ -78,6 +78,10 @@ class SubscribedLanguagesModal extends ImmutablePureComponent {
     const language = this.props.languages.find(language => language[0] === value);
     const checked = this.state.selectedLanguages.includes(value);
 
+    if (!language) {
+      return null;
+    }
+
     return (
       <Option
         key={value}
@@ -105,7 +109,7 @@ class SubscribedLanguagesModal extends ImmutablePureComponent {
           <p className='report-dialog-modal__lead'><FormattedMessage id='subscribed_languages.lead' defaultMessage='Only posts in selected languages will appear on your home and list timelines after the change. Select none to receive posts in all languages.' /></p>
 
           <div>
-            {availableLanguages.union(selectedLanguages).map(value => this.renderItem(value))}
+            {availableLanguages.union(selectedLanguages).delete(null).map(value => this.renderItem(value))}
           </div>
 
           <div className='flex-spacer' />