]> cat aescling's git repositories - mastodon.git/commitdiff
Update reply counters only if the reply is public/unlisted (#8211)
authorEugen Rochko <eugen@zeonfederated.com>
Thu, 16 Aug 2018 12:21:52 +0000 (14:21 +0200)
committerGitHub <noreply@github.com>
Thu, 16 Aug 2018 12:21:52 +0000 (14:21 +0200)
app/models/status.rb

index 1c87f2566f81c3500d6a53b976a8b6ac90912b1c..2eed336595a4aceb99f93b3428fe402ad8cf9c74 100644 (file)
@@ -456,8 +456,8 @@ class Status < ApplicationRecord
       Account.where(id: account_id).update_all('statuses_count = COALESCE(statuses_count, 0) + 1')
     end
 
-    thread.increment_count!(:replies_count) if in_reply_to_id.present?
     reblog.increment_count!(:reblogs_count) if reblog?
+    thread.increment_count!(:replies_count) if in_reply_to_id.present? && (public_visibility? || unlisted_visibility?)
   end
 
   def decrement_counter_caches
@@ -469,7 +469,7 @@ class Status < ApplicationRecord
       Account.where(id: account_id).update_all('statuses_count = GREATEST(COALESCE(statuses_count, 0) - 1, 0)')
     end
 
-    thread.decrement_count!(:replies_count) if in_reply_to_id.present?
     reblog.decrement_count!(:reblogs_count) if reblog?
+    thread.decrement_count!(:replies_count) if in_reply_to_id.present? && (public_visibility? || unlisted_visibility?)
   end
 end