]> cat aescling's git repositories - mastodon.git/commitdiff
Fix #83 - if user cannot be found (or is self) throw error, don't return empty 200
authorEugen Rochko <eugen@zeonfederated.com>
Thu, 6 Oct 2016 19:33:33 +0000 (21:33 +0200)
committerEugen Rochko <eugen@zeonfederated.com>
Thu, 6 Oct 2016 19:33:33 +0000 (21:33 +0200)
This prevents the undefined profile from being opened in the first place on such an error

app/services/follow_service.rb

index 4caf55078e579a979bda5485f68b83e717c61224..2a9dc82c38caaad61fb31353beb9ef82e3eba57b 100644 (file)
@@ -5,7 +5,7 @@ class FollowService < BaseService
   def call(source_account, uri)
     target_account = follow_remote_account_service.call(uri)
 
-    return nil if target_account.nil? || target_account.id == source_account.id
+    raise ActiveRecord::RecordNotFound if target_account.nil? || target_account.id == source_account.id
 
     follow = source_account.follow!(target_account)