Status removal is broadcast to public/hashtag timelines too

diff --git a/app/channels/application_cable/channel.rb b/app/channels/application_cable/channel.rb
index d27b058fb069f93a43aad11b3ddfe0830c9875b3..43adadbd90a5aede3021a4a947b44fcfa697333f 100644 (file)
--- a/app/channels/application_cable/channel.rb
+++ b/app/channels/application_cable/channel.rb
@@ -4,14 +4,17 @@ module ApplicationCable
 
     def hydrate_status(encoded_message)
       message = ActiveSupport::JSON.decode(encoded_message)
-      status  = Status.find_by(id: message['id'])
+
+      return [nil, message] if message['type'] == 'delete'
+
+      status             = Status.find_by(id: message['id'])
       message['message'] = FeedManager.instance.inline_render(current_user.account, status)
 
       [status, message]
     end
 
     def filter?(status)
-      status.nil? || current_user.account.blocking?(status.account) || (status.reblog? && current_user.account.blocking?(status.reblog.account))
+      !status.nil? && (current_user.account.blocking?(status.account) || (status.reblog? && current_user.account.blocking?(status.reblog.account)))
     end
   end
 end

diff --git a/app/services/remove_status_service.rb b/app/services/remove_status_service.rb
index 0b78b131a0bb95cbcff0d5a855a27b9f7804b189..66fa1be18fba350008f7b1685c7bbfb1a9a5789c 100644 (file)
--- a/app/services/remove_status_service.rb
+++ b/app/services/remove_status_service.rb
@@ -4,6 +4,8 @@ class RemoveStatusService < BaseService
     remove_from_followers(status)
     remove_from_mentioned(status)
     remove_reblogs(status)
+    remove_from_hashtags(status)
+    remove_from_public(status)
 
     status.destroy!
   end
@@ -49,6 +51,16 @@ class RemoveStatusService < BaseService
     FeedManager.instance.broadcast(receiver.id, type: 'delete', id: status.id)
   end
 
+  def remove_from_hashtags(status)
+    status.tags.each do |tag|
+      FeedManager.instance.broadcast("hashtag:#{tag.name}", type: 'delete', id: status.id)
+    end
+  end
+
+  def remove_from_public(status)
+    FeedManager.instance.broadcast(:public, type: 'delete', id: status.id)
+  end
+
   def redis
     $redis
   end