Fix invalid language resulting in no fallback being set on statuses (#17722)

diff --git a/app/helpers/languages_helper.rb b/app/helpers/languages_helper.rb
index f22cc6d28458a45360a137d2b96baa7090384fd4..9be35ad8ee2def7e3abefb70d65035c8fb381a67 100644 (file)
--- a/app/helpers/languages_helper.rb
+++ b/app/helpers/languages_helper.rb
@@ -241,6 +241,15 @@ module LanguagesHelper
     code
   end
 
+  def valid_locale_cascade(*arr)
+    arr.each do |str|
+      locale = valid_locale_or_nil(str)
+      return locale if locale.present?
+    end
+
+    nil
+  end
+
   def valid_locale?(locale)
     locale.present? && SUPPORTED_LOCALES.key?(locale.to_sym)
   end

diff --git a/app/services/post_status_service.rb b/app/services/post_status_service.rb
index b3bc4a0a29efbd061e3052019d1dfdd37583fe3d..7508c3b6460b12802d7ce7b41dde9a7267244c7f 100644 (file)
--- a/app/services/post_status_service.rb
+++ b/app/services/post_status_service.rb
@@ -162,7 +162,7 @@ class PostStatusService < BaseService
       sensitive: @sensitive,
       spoiler_text: @options[:spoiler_text] || '',
       visibility: @visibility,
-      language: valid_locale_or_nil(@options[:language].presence || @account.user&.preferred_posting_language || I18n.default_locale),
+      language: valid_locale_cascade(@options[:language], @account.user&.preferred_posting_language, I18n.default_locale),
       application: @options[:application],
       rate_limit: @options[:with_rate_limit],
     }.compact

diff --git a/app/services/update_status_service.rb b/app/services/update_status_service.rb
index 93203bc49425adc4c067ae25e35104ead11f7e1b..973e6ddee998e1c588f7832583424ee9f1ad143b 100644 (file)
--- a/app/services/update_status_service.rb
+++ b/app/services/update_status_service.rb
@@ -94,7 +94,7 @@ class UpdateStatusService < BaseService
     @status.text         = @options[:text].presence || @options.delete(:spoiler_text) || '' if @options.key?(:text)
     @status.spoiler_text = @options[:spoiler_text] || '' if @options.key?(:spoiler_text)
     @status.sensitive    = @options[:sensitive] || @options[:spoiler_text].present? if @options.key?(:sensitive) || @options.key?(:spoiler_text)
-    @status.language     = valid_locale_or_nil(@options[:language] || @status.language || @status.account.user&.preferred_posting_language || I18n.default_locale)
+    @status.language     = valid_locale_cascade(@options[:language], @status.language, @status.account.user&.preferred_posting_language, I18n.default_locale)
     @status.edited_at    = Time.now.utc
 
     @status.save!