Fix being able to appeal a strike unlimited times (#18529)

Peculiarity of the `has_one` association is that the convenience
creation method deletes the previous association even if the new
one is invalid

diff --git a/app/services/appeal_service.rb b/app/services/appeal_service.rb
index 1397c50f5faa7966ae87f21822d0821f3db1aec0..cef9be05fd04367326f3cb25a4e8eeec5172791f 100644 (file)
--- a/app/services/appeal_service.rb
+++ b/app/services/appeal_service.rb
@@ -14,7 +14,8 @@ class AppealService < BaseService
   private
 
   def create_appeal!
-    @appeal = @strike.create_appeal!(
+    @appeal = Appeal.create!(
+      strike: @strike,
       text: @text,
       account: @strike.target_account
     )