Fix search by IP not using alternative browser sessions in admin UI (#12904)

diff --git a/app/models/account_filter.rb b/app/models/account_filter.rb
index c1e6b0deba0719cd4cee494c712be160f3a3cd32..c7bf0778748c5863c07392a3e0437f05bfe587ed 100644 (file)
--- a/app/models/account_filter.rb
+++ b/app/models/account_filter.rb
@@ -65,7 +65,7 @@ class AccountFilter
     when 'email'
       accounts_with_users.merge User.matches_email(value)
     when 'ip'
-      valid_ip?(value) ? accounts_with_users.where('users.current_sign_in_ip <<= ?', value) : Account.none
+      valid_ip?(value) ? accounts_with_users.merge(User.matches_ip(value)) : Account.none
     when 'staff'
       accounts_with_users.merge User.staff
     else

diff --git a/app/models/user.rb b/app/models/user.rb
index 7147a9a319f53e3c060fce05c070c2602fa5f17e..a1753784d6c8d4fae7b885288163cf28b6dc8507 100644 (file)
--- a/app/models/user.rb
+++ b/app/models/user.rb
@@ -93,6 +93,7 @@ class User < ApplicationRecord
   scope :inactive, -> { where(arel_table[:current_sign_in_at].lt(ACTIVE_DURATION.ago)) }
   scope :active, -> { confirmed.where(arel_table[:current_sign_in_at].gteq(ACTIVE_DURATION.ago)).joins(:account).where(accounts: { suspended_at: nil }) }
   scope :matches_email, ->(value) { where(arel_table[:email].matches("#{value}%")) }
+  scope :matches_ip, ->(value) { left_joins(:session_activations).where('users.current_sign_in_ip <<= ?', value).or(left_joins(:session_activations).where('users.last_sign_in_ip <<= ?', value)).or(left_joins(:session_activations).where('session_activations.ip <<= ?', value)) }
   scope :emailable, -> { confirmed.enabled.joins(:account).merge(Account.searchable) }
 
   before_validation :sanitize_languages