Coverage for api/web/settings controller (#3238)

diff --git a/app/controllers/api/web/settings_controller.rb b/app/controllers/api/web/settings_controller.rb
index c00e016a4acd7b4d97d24ab50ece5802219b7588..7cceb0dfc794fefb75de6e6f1301d773cc12b593 100644 (file)
--- a/app/controllers/api/web/settings_controller.rb
+++ b/app/controllers/api/web/settings_controller.rb
@@ -6,10 +6,15 @@ class Api::Web::SettingsController < ApiController
   before_action :require_user!
 
   def update
-    setting      = ::Web::Setting.where(user: current_user).first_or_initialize(user: current_user)
     setting.data = params[:data]
     setting.save!
 
     render_empty
   end
+
+  private
+
+  def setting
+    @_setting ||= ::Web::Setting.where(user: current_user).first_or_initialize(user: current_user)
+  end
 end

diff --git a/spec/controllers/api/web/settings_controller_spec.rb b/spec/controllers/api/web/settings_controller_spec.rb
new file mode 100644 (file)
index 0000000..ff211c7
--- /dev/null
+++ b/spec/controllers/api/web/settings_controller_spec.rb
@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+describe Api::Web::SettingsController do
+  render_views
+
+  let!(:user) { Fabricate(:user) }
+
+  describe 'PATCH #update' do
+    it 'redirects to about page' do
+      sign_in(user)
+      patch :update, format: :json, params: { data: { 'onboarded' => true } }
+
+      user.reload
+      expect(response).to have_http_status(:success)
+      expect(user_web_setting.data['onboarded']).to eq('true')
+    end
+
+    def user_web_setting
+      Web::Setting.where(user: user).first
+    end
+  end
+end