]> cat aescling's git repositories - mastodon.git/commitdiff
Resolve confusion between ColumnBackButton and the slim version that
authorEugen Rochko <eugen@zeonfederated.com>
Mon, 30 Jan 2017 14:22:04 +0000 (15:22 +0100)
committerEugen Rochko <eugen@zeonfederated.com>
Mon, 30 Jan 2017 14:22:04 +0000 (15:22 +0100)
the public timeline has been using

app/assets/javascripts/components/components/column_back_button_slim.jsx [moved from app/assets/javascripts/components/features/public_timeline/components/column_back_button.jsx with 91% similarity]
app/assets/javascripts/components/features/favourited_statuses/index.jsx
app/assets/javascripts/components/features/follow_requests/index.jsx
app/assets/javascripts/components/features/hashtag_timeline/index.jsx
app/assets/javascripts/components/features/public_timeline/index.jsx

similarity index 91%
rename from app/assets/javascripts/components/features/public_timeline/components/column_back_button.jsx
rename to app/assets/javascripts/components/components/column_back_button_slim.jsx
index 4535f8f28346b344acf76f4d742efe64e5fbeae6..cdbe135057f895e0a6ab89502650bb27bab0216e 100644 (file)
@@ -18,7 +18,7 @@ const iconStyle = {
   marginRight: '5px'
 };
 
-const ColumnBackButton = React.createClass({
+const ColumnBackButtonSlim = React.createClass({
 
   contextTypes: {
     router: React.PropTypes.object
@@ -43,4 +43,4 @@ const ColumnBackButton = React.createClass({
 
 });
 
-export default ColumnBackButton;
+export default ColumnBackButtonSlim;
index a2d5217365bca5b300015ade91ba9bad9e4533b1..1e9dafbdde3a499dcdf568a4e226541af2daea65 100644 (file)
@@ -5,7 +5,7 @@ import LoadingIndicator from '../../components/loading_indicator';
 import { fetchFavouritedStatuses, expandFavouritedStatuses } from '../../actions/favourites';
 import Column from '../ui/components/column';
 import StatusList from '../../components/status_list';
-import ColumnBackButton from '../public_timeline/components/column_back_button';
+import ColumnBackButtonSlim from '../../components/column_back_button_slim';
 import { defineMessages, injectIntl } from 'react-intl';
 
 const messages = defineMessages({
@@ -52,7 +52,7 @@ const Favourites = React.createClass({
 
     return (
       <Column icon='star' heading={intl.formatMessage(messages.heading)}>
-        <ColumnBackButton />
+        <ColumnBackButtonSlim />
         <StatusList statusIds={statusIds} me={me} onScrollToBottom={this.handleScrollToBottom} />
       </Column>
     );
index 5c60b60282e78013e61091f12cde6d32d00f2201..3bee532c5cb29e5854a5a624c4e9334a0126ab30 100644 (file)
@@ -4,7 +4,7 @@ import ImmutablePropTypes from 'react-immutable-proptypes';
 import LoadingIndicator from '../../components/loading_indicator';
 import { ScrollContainer } from 'react-router-scroll';
 import Column from '../ui/components/column';
-import ColumnBackButton from '../../components/column_back_button';
+import ColumnBackButtonSlim from '../../components/column_back_button_slim';
 import AccountAuthorizeContainer from './containers/account_authorize_container';
 import { fetchFollowRequests, expandFollowRequests } from '../../actions/accounts';
 import { defineMessages, injectIntl } from 'react-intl';
@@ -52,7 +52,7 @@ const FollowRequests = React.createClass({
 
     return (
       <Column icon='users' heading={intl.formatMessage(messages.heading)}>
-        <ColumnBackButton />
+        <ColumnBackButtonSlim />
         <ScrollContainer scrollKey='follow_requests'>
           <div className='scrollable' onScroll={this.handleScroll}>
             {accountIds.map(id =>
index f28e01a0034c003799fd6d33586764140f666942..011b1e54dafc89b8c644801ecfd7878cd89266ef 100644 (file)
@@ -7,7 +7,7 @@ import {
   updateTimeline,
   deleteFromTimelines
 } from '../../actions/timelines';
-import ColumnBackButton from '../public_timeline/components/column_back_button';
+import ColumnBackButtonSlim from '../../components/column_back_button_slim';
 
 const HashtagTimeline = React.createClass({
 
@@ -27,10 +27,10 @@ const HashtagTimeline = React.createClass({
 
         received (data) {
           switch(data.type) {
-            case 'update':
-              return dispatch(updateTimeline('tag', JSON.parse(data.message)));
-            case 'delete':
-              return dispatch(deleteFromTimelines(data.id));
+          case 'update':
+            return dispatch(updateTimeline('tag', JSON.parse(data.message)));
+          case 'delete':
+            return dispatch(deleteFromTimelines(data.id));
           }
         }
 
@@ -69,7 +69,7 @@ const HashtagTimeline = React.createClass({
 
     return (
       <Column icon='hashtag' heading={id}>
-        <ColumnBackButton />
+        <ColumnBackButtonSlim />
         <StatusListContainer type='tag' id={id} />
       </Column>
     );
index eac85f01bd93967f24ab8b3b15516a3e074d45e4..28cdc639ad81cc7ef8fba1f60a8fd8529cd0b734 100644 (file)
@@ -8,7 +8,7 @@ import {
   deleteFromTimelines
 } from '../../actions/timelines';
 import { defineMessages, injectIntl } from 'react-intl';
-import ColumnBackButton from './components/column_back_button';
+import ColumnBackButtonSlim from '../../components/column_back_button_slim';
 
 const messages = defineMessages({
   title: { id: 'column.public', defaultMessage: 'Public' }
@@ -33,10 +33,10 @@ const PublicTimeline = React.createClass({
 
         received (data) {
           switch(data.type) {
-            case 'update':
-              return dispatch(updateTimeline('public', JSON.parse(data.message)));
-            case 'delete':
-              return dispatch(deleteFromTimelines(data.id));
+          case 'update':
+            return dispatch(updateTimeline('public', JSON.parse(data.message)));
+          case 'delete':
+            return dispatch(deleteFromTimelines(data.id));
           }
         }
 
@@ -55,7 +55,7 @@ const PublicTimeline = React.createClass({
 
     return (
       <Column icon='globe' heading={intl.formatMessage(messages.title)}>
-        <ColumnBackButton />
+        <ColumnBackButtonSlim />
         <StatusListContainer type='public' />
       </Column>
     );