Fix webpack-dev-server on Windows (#4000)

* Fix webpack-dev-server on Windows

* Serve webpack from 0.0.0.0, access at 127.0.0.1

diff --git a/bin/webpack-dev-server b/bin/webpack-dev-server
index a867f2c0137a2a1b55e57ee125533fcd273266e7..0beec31753b667f16cdc06f8c29d3c87bc3c8088 100755 (executable)
--- a/bin/webpack-dev-server
+++ b/bin/webpack-dev-server
@@ -23,7 +23,7 @@ end
 begin
   dev_server = YAML.load_file(CONFIG_FILE)["development"]["dev_server"]
 
-  DEV_SERVER_HOST = "http#{"s" if args('--https') || dev_server["https"]}://#{args('--host') || dev_server["host"]}:#{args('--port') || dev_server["port"]}"
+  DEV_SERVER_HOST = "http#{"s" if args('--https') || dev_server["https"]}://#{dev_server["host"]}:#{args('--port') || dev_server["port"]}"
 
 rescue Errno::ENOENT, NoMethodError
   puts "Webpack dev_server configuration not found in #{CONFIG_FILE}."

diff --git a/config/webpacker.yml b/config/webpacker.yml
index c1cd6e93b27bdb1d132569633a79f8ea20cb5662..aa429a1ddac44a1392cbb9abc645189ea0b12735 100644 (file)
--- a/config/webpacker.yml
+++ b/config/webpacker.yml
@@ -19,7 +19,7 @@ development:
   <<: *default
 
   dev_server:
-    host: 0.0.0.0
+    host: 127.0.0.1
     port: 8080
     https: false