Guard against nil URLs in Request class (#7284)

Fix #7265

diff --git a/app/lib/request.rb b/app/lib/request.rb
index 0acd654da0441fadeb35c1642b074c459e8673af..00f94dacf5c1f00dae99a10e39ece7aab2fb63e9 100644 (file)
--- a/app/lib/request.rb
+++ b/app/lib/request.rb
@@ -9,12 +9,15 @@ class Request
   include RoutingHelper
 
   def initialize(verb, url, **options)
+    raise ArgumentError if url.blank?
+
     @verb    = verb
     @url     = Addressable::URI.parse(url).normalize
     @options = options.merge(use_proxy? ? Rails.configuration.x.http_client_proxy : { socket_class: Socket })
     @headers = {}
 
     raise Mastodon::HostValidationError, 'Instance does not support hidden service connections' if block_hidden_service?
+
     set_common_headers!
     set_digest! if options.key?(:body)
   end

diff --git a/app/services/activitypub/fetch_featured_collection_service.rb b/app/services/activitypub/fetch_featured_collection_service.rb
index 40714e98012b880da60d2b158ddb5bd0bb47c0d5..6a137b520bdc4906105dea7099aadb6061fae4d3 100644 (file)
--- a/app/services/activitypub/fetch_featured_collection_service.rb
+++ b/app/services/activitypub/fetch_featured_collection_service.rb
@@ -4,6 +4,8 @@ class ActivityPub::FetchFeaturedCollectionService < BaseService
   include JsonLdHelper
 
   def call(account)
+    return if account.featured_collection_url.blank?
+
     @account = account
     @json    = fetch_resource(@account.featured_collection_url, true)