Add fa-fw class to user agent icon (#4047)

diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
index 36c37fae08ffbdd5f98877c1184d70f2bae50b46..9f50d8bdb32876df84b479e9d000bfffb6ab12cf 100644 (file)
--- a/app/helpers/application_helper.rb
+++ b/app/helpers/application_helper.rb
@@ -31,7 +31,11 @@ module ApplicationHelper
     Rails.env.production? ? site_title : "#{site_title} (Dev)"
   end
 
-  def fa_icon(icon)
-    content_tag(:i, nil, class: 'fa ' + icon.split(' ').map { |cl| "fa-#{cl}" }.join(' '))
+  def fa_icon(icon, attributes = {})
+    class_names = attributes[:class]&.split(' ') || []
+    class_names << 'fa'
+    class_names += icon.split(' ').map { |cl| "fa-#{cl}" }
+
+    content_tag(:i, nil, attributes.merge(class: class_names.join(' ')))
   end
 end

diff --git a/app/views/auth/registrations/_sessions.html.haml b/app/views/auth/registrations/_sessions.html.haml
index 11c0d4e315f998272eabd1e9c9744e4a8815a276..4521aad0a2bec4fdf119d0022ef6e612843ff0b3 100644 (file)
--- a/app/views/auth/registrations/_sessions.html.haml
+++ b/app/views/auth/registrations/_sessions.html.haml
@@ -11,9 +11,10 @@
     - @sessions.each do |session|
       %tr
         %td
-          %span{ title: session.user_agent }= fa_icon session_device_icon(session)
-          = ' '
-          = t 'sessions.description', browser: t("sessions.browsers.#{session.browser}"), platform: t("sessions.platforms.#{session.platform}")
+          %span{ title: session.user_agent }<
+            = fa_icon "#{session_device_icon(session)} fw", 'aria-label' => session_device_icon(session)
+            = ' '
+            = t 'sessions.description', browser: t("sessions.browsers.#{session.browser}"), platform: t("sessions.platforms.#{session.platform}")
         %td
           %samp= session.ip
         %td