Use Tombstone and _:atomUri in Delete activities as fallback (#4704)

diff --git a/app/lib/activitypub/activity/delete.rb b/app/lib/activitypub/activity/delete.rb
index 23f3430fb6e6de81c67975151916015ac694dc3b..a1598dfd32a99fc3049a6f1b2e86819f952260c3 100644 (file)
--- a/app/lib/activitypub/activity/delete.rb
+++ b/app/lib/activitypub/activity/delete.rb
@@ -2,7 +2,8 @@
 
 class ActivityPub::Activity::Delete < ActivityPub::Activity
   def perform
-    status = Status.find_by(uri: object_uri, account: @account)
+    status   = Status.find_by(uri: object_uri, account: @account)
+    status ||= Status.find_by(uri: @object['_:atomUri'], account: @account) if @object.is_a?(Hash) && @object['_:atomUri'].present?
 
     if status.nil?
       delete_later!(object_uri)

diff --git a/app/serializers/activitypub/delete_serializer.rb b/app/serializers/activitypub/delete_serializer.rb
index b49268d72a31dfb9f3d0b8616b138f619eb1228b..a041c577b3ffcefabc7977d5ac66b4b759fd0803 100644 (file)
--- a/app/serializers/activitypub/delete_serializer.rb
+++ b/app/serializers/activitypub/delete_serializer.rb
@@ -1,8 +1,26 @@
 # frozen_string_literal: true
 
 class ActivityPub::DeleteSerializer < ActiveModel::Serializer
+  class TombstoneSerializer < ActiveModel::Serializer
+    attributes :id, :type
+    attribute :atom_uri, key: '_:atomUri'
+
+    def id
+      ActivityPub::TagManager.instance.uri_for(object)
+    end
+
+    def type
+      'Tombstone'
+    end
+
+    def atom_uri
+      ::TagManager.instance.uri_for(object)
+    end
+  end
+
   attributes :id, :type, :actor
-  attribute :virtual_object, key: :object
+
+  has_one :object, serializer: TombstoneSerializer
 
   def id
     [ActivityPub::TagManager.instance.uri_for(object), '#delete'].join
@@ -15,8 +33,4 @@ class ActivityPub::DeleteSerializer < ActiveModel::Serializer
   def actor
     ActivityPub::TagManager.instance.uri_for(object.account)
   end
-
-  def virtual_object
-    ActivityPub::TagManager.instance.uri_for(object)
-  end
 end