]> cat aescling's git repositories - mastodon.git/commitdiff
Do not fetch preview card for mentioned users (#6934)
authorThibG <thib@sitedethib.com>
Thu, 25 Oct 2018 16:13:19 +0000 (18:13 +0200)
committerEugen Rochko <eugen@zeonfederated.com>
Thu, 25 Oct 2018 16:13:19 +0000 (18:13 +0200)
app/services/fetch_link_card_service.rb

index 4169c685bd646dffdf7d6cee89f3b154b0198a8a..4551aa7e0b3c9f08ecebe817cc913dce3b34bef9 100644 (file)
@@ -17,7 +17,8 @@ class FetchLinkCardService < BaseService
 
     return if @url.nil? || @status.preview_cards.any?
 
-    @url = @url.to_s
+    @mentions = status.mentions
+    @url      = @url.to_s
 
     RedisLock.acquire(lock_options) do |lock|
       if lock.acquired?
@@ -81,9 +82,16 @@ class FetchLinkCardService < BaseService
     uri.host.blank? || TagManager.instance.local_url?(uri.to_s) || !%w(http https).include?(uri.scheme)
   end
 
+  def mention_link?(a)
+    return false if @mentions.nil?
+    @mentions.any? do |mention|
+      a['href'] == TagManager.instance.url_for(mention.target)
+    end
+  end
+
   def skip_link?(a)
     # Avoid links for hashtags and mentions (microformats)
-    a['rel']&.include?('tag') || a['class']&.include?('u-url')
+    a['rel']&.include?('tag') || a['class']&.include?('u-url') || mention_link?(a)
   end
 
   def attempt_oembed