Restoring old async behaviour of thread resolving as it proved to be more robust

diff --git a/app/services/process_feed_service.rb b/app/services/process_feed_service.rb
index a525bc321671f15018ef509879bd74d2ff84ac10..3860a3504f09ec147a994ef2419c4e4182d84d09 100644 (file)
--- a/app/services/process_feed_service.rb
+++ b/app/services/process_feed_service.rb
@@ -122,7 +122,7 @@ class ProcessFeedService < BaseService
     def find_or_resolve_status(parent, uri, url)
       status = find_status(uri)
 
-      ResolveThread.new.call(parent, url) if status.nil?
+      ThreadResolveWorker.perform_async(parent.id, url) if status.nil?
 
       status
     end
@@ -243,15 +243,4 @@ class ProcessFeedService < BaseService
       "#{username}@#{domain}"
     end
   end
-
-  class ResolveThread
-    def call(child_status, parent_url)
-      parent_status = FetchRemoteStatusService.new.call(parent_url)
-
-      return if parent_status.nil?
-
-      child_status.thread = parent_status
-      child_status.save!
-    end
-  end
 end

diff --git a/app/workers/pubsubhubbub/delivery_worker.rb b/app/workers/pubsubhubbub/delivery_worker.rb
index 20c72ce2434beccbb8a0bde55a4d9be562aea056..35bf7b2f07e7f4e3263ecdf33f7f7b3bdb144500 100644 (file)
--- a/app/workers/pubsubhubbub/delivery_worker.rb
+++ b/app/workers/pubsubhubbub/delivery_worker.rb
@@ -4,7 +4,7 @@ class Pubsubhubbub::DeliveryWorker
   include Sidekiq::Worker
   include RoutingHelper
 
-  sidekiq_options queue: 'push'
+  sidekiq_options queue: 'push', retry: 5
 
   def perform(subscription_id, payload)
     subscription = Subscription.find(subscription_id)

diff --git a/app/workers/thread_resolve_worker.rb b/app/workers/thread_resolve_worker.rb
new file mode 100644 (file)
index 0000000..84eae73
--- /dev/null
+++ b/app/workers/thread_resolve_worker.rb
@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+class ThreadResolveWorker
+  include Sidekiq::Worker
+
+  def perform(child_status_id, parent_url)
+    child_status  = Status.find(child_status_id)
+    parent_status = FetchRemoteStatusService.new.call(parent_url)
+
+    return if parent_status.nil?
+
+    child_status.thread = parent_status
+    child_status.save!
+  end
+end