Accessability fixes (#4432)

* fix(modal_root): Read type from props, not from component

* fix(status_list): Do not user event.path

diff --git a/app/javascript/mastodon/components/status_list.js b/app/javascript/mastodon/components/status_list.js
index d87fe3ea16a1fc73d9bf09cba233810429db9b54..e945e878c96a697694ac232c94e1f7b4ec7b8993 100644 (file)
--- a/app/javascript/mastodon/components/status_list.js
+++ b/app/javascript/mastodon/components/status_list.js
@@ -109,9 +109,9 @@ export default class StatusList extends ImmutablePureComponent {
       const article = (() => {
         switch (e.key) {
         case 'PageDown':
-          return e.nativeEvent.path[0].nodeName === 'ARTICLE' && e.nativeEvent.path[0].nextElementSibling;
+          return e.target.nodeName === 'ARTICLE' && e.target.nextElementSibling;
         case 'PageUp':
-          return e.nativeEvent.path[0].nodeName === 'ARTICLE' && e.nativeEvent.path[0].previousElementSibling;
+          return e.target.nodeName === 'ARTICLE' && e.target.previousElementSibling;
         case 'End':
           return this.node.querySelector('[role="feed"] > article:last-of-type');
         case 'Home':

diff --git a/app/javascript/mastodon/features/ui/components/modal_root.js b/app/javascript/mastodon/features/ui/components/modal_root.js
index 3ca19e4d572083f0c66a98e6bb7765774534cff6..5b598bddf3f5231030f43a6e3fc49c7def0e9830 100644 (file)
--- a/app/javascript/mastodon/features/ui/components/modal_root.js
+++ b/app/javascript/mastodon/features/ui/components/modal_root.js
@@ -53,7 +53,7 @@ export default class ModalRoot extends React.PureComponent {
   }
 
   componentDidUpdate (prevProps) {
-    if (!this.type && !!prevProps.type) {
+    if (!this.props.type && !!prevProps.type) {
       this.getSiblings().forEach(sibling => sibling.removeAttribute('inert'));
       this.activeElement.focus();
       this.activeElement = null;