Disable the Rubocop Style/GuardClause cop (#3316)

There are many spots throughout the codebase which are showing as covered by
specs in the simplecov output -- but which are not actually run, because they
are on the same line as a guard clause.

I plan on fixing some of these issues, but don't want to keep triggering this
rubocop style violation.

My preference would be that we use the PR review process to identify places
where a guard clause might be appropriate, but that we leave this cop turned off
by default.

diff --git a/.rubocop.yml b/.rubocop.yml
index 674865c46855c1445f4b179feaa679c738547d3c..295787e267fb28de88e2f40380b8180f73ef1ff2 100644 (file)
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -74,6 +74,9 @@ Style/RegexpLiteral:
 Style/Lambda:
   Enabled: false
 
+Style/GuardClause:
+  Enabled: false
+
 Rails/HasAndBelongsToMany:
   Enabled: false