Reports spec for media attachments, clean up method (#2660)

* Add coverage for Report#media_attachments

* Direct query on media attachment

diff --git a/app/models/report.rb b/app/models/report.rb
index c7d88774580ce0a3bc05dafc0529220d1388832c..d813d0d0d18075110fa14d9383cb09f2fe829648 100644 (file)
--- a/app/models/report.rb
+++ b/app/models/report.rb
@@ -13,10 +13,6 @@ class Report < ApplicationRecord
   end
 
   def media_attachments
-    media_attachments = []
-    statuses.each do |s|
-      media_attachments.concat s.media_attachments
-    end
-    media_attachments
+    MediaAttachment.where(status_id: status_ids)
   end
 end

diff --git a/spec/models/report_spec.rb b/spec/models/report_spec.rb
index 80b8cc55b55478cd043cf7886b185a69c29f08ef..6c2723845709653afbef837f05d8c222de48140b 100644 (file)
--- a/spec/models/report_spec.rb
+++ b/spec/models/report_spec.rb
@@ -10,4 +10,15 @@ describe Report do
       expect(report.statuses).to eq [status]
     end
   end
+
+  describe 'media_attachments' do
+    it 'returns media attachments from statuses' do
+      status = Fabricate(:status)
+      media_attachment = Fabricate(:media_attachment, status: status)
+      _other_media_attachment = Fabricate(:media_attachment)
+      report = Fabricate(:report, status_ids: [status.id])
+
+      expect(report.media_attachments).to eq [media_attachment]
+    end
+  end
 end