Fixed small bugs and code style offences

diff --git a/app/helpers/atom_helper.rb b/app/helpers/atom_helper.rb
index f091d1afee64ad00475c7f11467927366fe0f9fc..f8675db3bc3dde400fe76891b46361fee0c9a334 100644 (file)
--- a/app/helpers/atom_helper.rb
+++ b/app/helpers/atom_helper.rb
@@ -7,7 +7,7 @@ module AtomHelper
     if is_root
       root_tag(xml, :entry, &block)
     else
-      xml.entry &block
+      xml.entry(&block)
     end
   end
 
@@ -44,11 +44,11 @@ module AtomHelper
   end
 
   def author(xml, &block)
-    xml.author &block
+    xml.author(&block)
   end
 
   def target(xml, &block)
-    xml['activity'].object &block
+    xml['activity'].object(&block)
   end
 
   def object_type(xml, type)
@@ -177,6 +177,6 @@ module AtomHelper
   private
 
   def root_tag(xml, tag, &block)
-    xml.send(tag, {xmlns: 'http://www.w3.org/2005/Atom', 'xmlns:thr': 'http://purl.org/syndication/thread/1.0', 'xmlns:activity': 'http://activitystrea.ms/spec/1.0/', 'xmlns:poco': 'http://portablecontacts.net/spec/1.0'}, &block)
+    xml.send(tag, { :xmlns => 'http://www.w3.org/2005/Atom', 'xmlns:thr' => 'http://purl.org/syndication/thread/1.0', 'xmlns:activity' => 'http://activitystrea.ms/spec/1.0/', 'xmlns:poco' => 'http://portablecontacts.net/spec/1.0' }, &block)
   end
 end

diff --git a/app/services/follow_remote_account_service.rb b/app/services/follow_remote_account_service.rb
index de2ca6e7544a98a2da9687513c367ccc491ec041..8e01991347c43fe0be3be06beff105f47a2ade4e 100644 (file)
--- a/app/services/follow_remote_account_service.rb
+++ b/app/services/follow_remote_account_service.rb
@@ -45,7 +45,7 @@ class FollowRemoteAccountService < BaseService
     end
 
     return account
-  rescue Goldfinger::Error, HTTP::Error => e
+  rescue Goldfinger::Error, HTTP::Error
     nil
   end
 

diff --git a/app/services/process_feed_service.rb b/app/services/process_feed_service.rb
index 210de8cdb6edef0d943cf06dea0bc243d88b5e30..6ce74e32d72ea3af49a919311eef45ba3203bc7c 100644 (file)
--- a/app/services/process_feed_service.rb
+++ b/app/services/process_feed_service.rb
@@ -28,7 +28,7 @@ class ProcessFeedService < BaseService
 
   private
 
-  def add_post!(entry, status)
+  def add_post!(_entry, status)
     status.save!
   end
 
@@ -47,7 +47,7 @@ class ProcessFeedService < BaseService
     status.save!
   end
 
-  def find_original_status(xml, id)
+  def find_original_status(_xml, id)
     return nil if id.nil?
 
     if local_id?(id)
@@ -96,7 +96,7 @@ class ProcessFeedService < BaseService
   end
 
   def activity_id(xml)
-    entry.at_xpath('./xmlns:id').content
+    xml.at_xpath('./xmlns:id').content
   end
 
   def target_content(xml)

diff --git a/app/services/process_interaction_service.rb b/app/services/process_interaction_service.rb
index 3a8332118ed99f9f7ccc9021d5e8e4cb69a6864c..7bd813c0e1d9c58b65e5879ba05b6e9ba7e1462e 100644 (file)
--- a/app/services/process_interaction_service.rb
+++ b/app/services/process_interaction_service.rb
@@ -68,7 +68,7 @@ class ProcessInteractionService < BaseService
   end
 
   def status(xml)
-    Status.find(unique_tag_to_local_id(activity_id, 'Status'))
+    Status.find(unique_tag_to_local_id(activity_id(xml), 'Status'))
   end
 
   def activity_id(xml)