Return missing page when tag does not exist (#2563)

diff --git a/app/controllers/tags_controller.rb b/app/controllers/tags_controller.rb
index d99aea2ebeb56c5b9df5f6e1b24eeaa2eab952ce..53149edf0a4b45c1168f79876c5df172428d1a65 100644 (file)
--- a/app/controllers/tags_controller.rb
+++ b/app/controllers/tags_controller.rb
@@ -4,7 +4,7 @@ class TagsController < ApplicationController
   layout 'public'
 
   def show
-    @tag      = Tag.find_by(name: params[:id].downcase)
+    @tag      = Tag.find_by!(name: params[:id].downcase)
     @statuses = @tag.nil? ? [] : Status.as_tag_timeline(@tag, current_account, params[:local]).paginate_by_max_id(20, params[:max_id])
     @statuses = cache_collection(@statuses, Status)
   end

diff --git a/spec/controllers/tags_controller_spec.rb b/spec/controllers/tags_controller_spec.rb
index 80007ecdad48d809ab957c30e5d80aa2b721e3b0..f1119ebce2f3f302502e9ed94eeaef468db2120d 100644 (file)
--- a/spec/controllers/tags_controller_spec.rb
+++ b/spec/controllers/tags_controller_spec.rb
@@ -12,5 +12,11 @@ RSpec.describe TagsController, type: :controller do
       get :show, params: { id: 'test' }
       expect(response).to have_http_status(:success)
     end
+
+    it 'returns http missing for non-existent tag' do
+      get :show, params: { id: 'none' }
+
+      expect(response).to have_http_status(:missing)
+    end
   end
 end