Adjust REDIS_URL usage in node_redis (#3183)

Resolves #2780

diff --git a/config/initializers/redis.rb b/config/initializers/redis.rb
index 63fc425573af358e0f6175f3cec3917b3aff473b..4ed53ec07d9bd62510f737eba83c2eca6e2e751e 100644 (file)
--- a/config/initializers/redis.rb
+++ b/config/initializers/redis.rb
@@ -17,8 +17,9 @@ redis_connection = Redis.new(
 cache_params = { expires_in: 10.minutes }
 
 namespace = ENV.fetch('REDIS_NAMESPACE') { nil }
+
 if namespace
-  Redis.current = Redis::Namespace.new(namespace, :redis => redis_connection)
+  Redis.current = Redis::Namespace.new(namespace, redis: redis_connection)
   cache_params[:namespace] = namespace + '_cache'
 else
   Redis.current = redis_connection

diff --git a/streaming/index.js b/streaming/index.js
index cd19631218b17481524d00ca3f2b49302863f12c..b020d59fc4d8c5769bf9cac97d00c16b99ce8eaf 100644 (file)
--- a/streaming/index.js
+++ b/streaming/index.js
@@ -41,6 +41,7 @@ const dbUrlToConfig = (dbUrl) => {
   }
 
   const ssl = params.query && params.query.ssl;
+
   if (ssl) {
     config.ssl = ssl === 'true' || ssl === '1';
   }
@@ -48,6 +49,22 @@ const dbUrlToConfig = (dbUrl) => {
   return config;
 };
 
+const redisUrlToClient = (defaultConfig, redisUrl) => {
+  const config = defaultConfig;
+
+  if (!redisUrl) {
+    return redis.createClient(config);
+  }
+
+  if (redisUrl.startsWith('unix://')) {
+    return redis.createClient(redisUrl.slice(7), config);
+  }
+
+  return redis.createClient(Object.assign(config, {
+    url: redisUrl,
+  }));
+};
+
 if (cluster.isMaster) {
   // Cluster master
   const core = +process.env.STREAMING_CLUSTER_NUM || (env === 'development' ? 1 : Math.max(os.cpus().length - 1, 1));
@@ -94,15 +111,15 @@ if (cluster.isMaster) {
     port:     process.env.REDIS_PORT     || 6379,
     db:       process.env.REDIS_DB       || 0,
     password: process.env.REDIS_PASSWORD,
-    url:      process.env.REDIS_URL      || null,
   };
 
   if (redisNamespace) {
     redisParams.namespace = redisNamespace;
   }
+
   const redisPrefix = redisNamespace ? `${redisNamespace}:` : '';
 
-  const redisClient = redis.createClient(redisParams);
+  const redisClient = redisUrlToClient(redisParams, process.env.REDIS_URL);
 
   const subs = {};