]> cat aescling's git repositories - mastodon.git/commitdiff
Rename DropdownMenu's ariaLabel to title, to reduce unnecessary changes with upstream
authorThibaut Girka <thib@sitedethib.com>
Sat, 25 Jan 2020 09:17:13 +0000 (10:17 +0100)
committerThibaut Girka <thib@sitedethib.com>
Sat, 25 Jan 2020 09:17:13 +0000 (10:17 +0100)
app/javascript/flavours/glitch/components/dropdown_menu.js
app/javascript/flavours/glitch/features/status/components/action_bar.js

index ab5b7a572d62eaab3e848687908559d6ddd26226..cc4d714e8a0b7b3baadd4a7f9c7598bf96016848 100644 (file)
@@ -184,7 +184,7 @@ export default class Dropdown extends React.PureComponent {
     icon: PropTypes.string.isRequired,
     items: PropTypes.array.isRequired,
     size: PropTypes.number.isRequired,
-    ariaLabel: PropTypes.string,
+    title: PropTypes.string,
     disabled: PropTypes.bool,
     status: ImmutablePropTypes.map,
     isUserTouching: PropTypes.func,
@@ -197,7 +197,7 @@ export default class Dropdown extends React.PureComponent {
   };
 
   static defaultProps = {
-    ariaLabel: 'Menu',
+    title: 'Menu',
   };
 
   state = {
@@ -277,14 +277,14 @@ export default class Dropdown extends React.PureComponent {
   }
 
   render () {
-    const { icon, items, size, ariaLabel, disabled, dropdownPlacement, openDropdownId, openedViaKeyboard } = this.props;
+    const { icon, items, size, title, disabled, dropdownPlacement, openDropdownId, openedViaKeyboard } = this.props;
     const open = this.state.id === openDropdownId;
 
     return (
       <div>
         <IconButton
           icon={icon}
-          title={ariaLabel}
+          title={title}
           active={open}
           disabled={disabled}
           size={size}
index c48bfaccd80a7f53816b837fe110804f6067e86c..8f6f358d8cbf3cb0d5dbc64f093b5f8d78e94218 100644 (file)
@@ -207,7 +207,7 @@ class ActionBar extends React.PureComponent {
         <div className='detailed-status__button'><IconButton className='bookmark-icon' active={status.get('bookmarked')} title={intl.formatMessage(messages.bookmark)} icon='bookmark' onClick={this.handleBookmarkClick} /></div>
 
         <div className='detailed-status__action-bar-dropdown'>
-          <DropdownMenuContainer size={18} icon='ellipsis-h' items={menu} direction='left' ariaLabel='More' />
+          <DropdownMenuContainer size={18} icon='ellipsis-h' items={menu} direction='left' title='More' />
         </div>
       </div>
     );