Fixed bug that timeline can not be displayed by InvalidURIError (#2947)

diff --git a/app/lib/formatter.rb b/app/lib/formatter.rb
index 12b030e11752e5524c5edec3a24ec09ff19adda7..0f2989a81f1851ad2a87fb2b0e023ae581e29fa6 100644 (file)
--- a/app/lib/formatter.rb
+++ b/app/lib/formatter.rb
@@ -92,6 +92,8 @@ class Formatter
       rel: 'nofollow noopener',
     }
     Twitter::Autolink.send(:link_to_text, entity, link_html(entity[:url]), normalized_url, html_attrs)
+  rescue Addressable::URI::InvalidURIError
+    encode(entity[:url])
   end
 
   def link_to_mention(entity, mentions)

diff --git a/spec/lib/formatter_spec.rb b/spec/lib/formatter_spec.rb
index 81eaf00e804e78dad4af6a1313914a7e96b9e47a..791bcce8664a68bbf92c30d6e83c6ee39a0bc7a3 100644 (file)
--- a/spec/lib/formatter_spec.rb
+++ b/spec/lib/formatter_spec.rb
@@ -123,6 +123,13 @@ RSpec.describe Formatter do
         expect(subject).to match '<p>&lt;img src=&quot;javascript:alert(&apos;XSS&apos;);&quot;&gt;</p>'
       end
     end
+
+    context 'contains invalid URL' do
+      let(:local_text) { 'http://www\.google\.com' }
+      it 'has valid url' do
+        expect(subject).to eq '<p>http://www\.google\.com</p>'
+      end
+    end
   end
 
   describe '#reformat' do