]> cat aescling's git repositories - mastodon.git/commit
Remove support for OAUTH_REDIRECT_AT_SIGN_IN (#17287)
authorClaire <claire.github-309c@sitedethib.com>
Sun, 23 Jan 2022 14:50:41 +0000 (15:50 +0100)
committerGitHub <noreply@github.com>
Sun, 23 Jan 2022 14:50:41 +0000 (15:50 +0100)
commitcfa583fa7111cfc16b9ce548f9d9b58963f154bd
treed5a05bb60b61f0afbe2ecb993022f092bdf12af7
parent8a07ecd3773b1beae607bfe1edde62104654d64f
Remove support for OAUTH_REDIRECT_AT_SIGN_IN (#17287)

Fixes #15959

Introduced in #6540, OAUTH_REDIRECT_AT_SIGN_IN allowed skipping the log-in form
to instead redirect to the external OmniAuth login provider.

However, it did not prevent the log-in form on /about introduced by #10232 from
appearing, and completely broke with the introduction of #15228.

As I restoring that previous log-in flow without introducing a security
vulnerability may require extensive care and knowledge of how OmniAuth works,
this commit removes support for OAUTH_REDIRECT_AT_SIGN_IN instead for the time
being.
.env.nanobox
app/controllers/auth/sessions_controller.rb
config/initializers/omniauth.rb