]> cat aescling's git repositories - mastodon.git/commit
Fix URI of repeat follow requests not being recorded (#15662)
authorClaire <claire.github-309c@sitedethib.com>
Thu, 11 Feb 2021 00:53:44 +0000 (01:53 +0100)
committerGitHub <noreply@github.com>
Thu, 11 Feb 2021 00:53:44 +0000 (01:53 +0100)
commitbe3b9f81518196f73f2b9636137732659df8cc5b
treec3313f525f9d153459e0a164bb40f8a8a9dcfb81
parentf5fefdc11aee24626d78480766fda878911f58b7
Fix URI of repeat follow requests not being recorded (#15662)

* Fix URI of repeat follow requests not being recorded

In case we receive a “repeat” or “duplicate” follow request, we automatically
fast-forward the accept with the latest received Activity `id`, but we don't
record it.

In general, a “repeat” or “duplicate” follow request may happen if for some
reason (e.g. inconsistent handling of Block or Undo Accept activities, an
instance being brought back up from the dead, etc.) the local instance thought
the remote actor were following them while the remote actor thought otherwise.

In those cases, the remote instance does not know about the older Follow
activity `id`, so keeping that record serves no purpose, but knowing the most
recent one is useful if the remote implementation at some point refers to it
by `id` without inlining it.

* Add tests
app/lib/activitypub/activity/follow.rb
spec/lib/activitypub/activity/follow_spec.rb