]> cat aescling's git repositories - mastodon.git/commit
Add OMNIAUTH_ONLY environment variable to enforce externa log-in (#17288)
authorClaire <claire.github-309c@sitedethib.com>
Sun, 23 Jan 2022 14:52:58 +0000 (15:52 +0100)
committerGitHub <noreply@github.com>
Sun, 23 Jan 2022 14:52:58 +0000 (15:52 +0100)
commitbddd9ba36d9f4e86e2a4bbea77f967c143afa2cc
tree8614b0600d7b8f0a0186b4a0711ff49f26fdff88
parentcfa583fa7111cfc16b9ce548f9d9b58963f154bd
Add OMNIAUTH_ONLY environment variable to enforce externa log-in (#17288)

* Remove support for OAUTH_REDIRECT_AT_SIGN_IN

Fixes #15959

Introduced in #6540, OAUTH_REDIRECT_AT_SIGN_IN allowed skipping the log-in form
to instead redirect to the external OmniAuth login provider.

However, it did not prevent the log-in form on /about introduced by #10232 from
appearing, and completely broke with the introduction of #15228.

As I restoring that previous log-in flow without introducing a security
vulnerability may require extensive care and knowledge of how OmniAuth works,
this commit removes support for OAUTH_REDIRECT_AT_SIGN_IN instead for the time
being.

* Add OMNIAUTH_ONLY environment variable to enforce external log-in only

* Disable user registration when OMNIAUTH_ONLY is set to true

* Replace log-in links When OMNIAUTH_ONLY is set with exactly one OmniAuth provider
app/controllers/api/v1/accounts_controller.rb
app/controllers/auth/registrations_controller.rb
app/helpers/application_helper.rb
app/views/about/_login.html.haml
app/views/auth/sessions/new.html.haml
app/views/auth/shared/_links.html.haml
app/views/layouts/public.html.haml
app/views/statuses/_status.html.haml
config/locales/en.yml