]> cat aescling's git repositories - mastodon.git/commit
Fix account deletion sometimes failing because of optimistic locks (#16317)
authorClaire <claire.github-309c@sitedethib.com>
Wed, 2 Jun 2021 15:41:25 +0000 (17:41 +0200)
committerGitHub <noreply@github.com>
Wed, 2 Jun 2021 15:41:25 +0000 (17:41 +0200)
commit526332c5454b67f1c498dc82e71657258a79d7e9
treebd640e245c1d996705d865f49ea59dc84b10318a
parentbe8079f63783691dd9fdec3f79b744a5bfdb2b0f
Fix account deletion sometimes failing because of optimistic locks (#16317)

* Fix account deletion sometimes failing because of optimistic locks

In some rare occasions[1], deleting accounts would fail with a
`StaleObjectError` exception.

Indeed, account deletion manually sets the `AccountStat` values without
handling cases where the optimistic locking on `AccountStat` would fail.

To my knowledge, with the rewrite of account counters in #15913, the
`DeleteAccountService` is now the only place that changes the counters in
a way that is not atomic.

Since in this specific case, we do not care about the previous values of the
account counters, it appears we don't need locking at all for this table
anymore.

[1]: https://discourse.joinmastodon.org/t/account-cant-be-deleted/3602

* Bump MAX_SUPPORTED_VERSION in maintenance script
app/models/account_stat.rb
app/models/concerns/account_counters.rb
db/post_migrate/20210526193025_remove_lock_version_from_account_stats.rb [new file with mode: 0644]
db/schema.rb
lib/mastodon/maintenance_cli.rb