]> cat aescling's git repositories - mastodon.git/commit
Fix old migrations failing because of strong_migrations update (#12692)
authorThibG <thib@sitedethib.com>
Sun, 29 Dec 2019 04:39:08 +0000 (05:39 +0100)
committerEugen Rochko <eugen@zeonfederated.com>
Sun, 29 Dec 2019 04:39:08 +0000 (05:39 +0100)
commit1155dc08352c3aa1cb763729122c34a3db6e64ec
treea33d5437ff70fbfb4fdc3b093f2af2b5ea9d26e3
parent7ff7ca8c7c8d6612760db93d533a18e83b0a9c70
Fix old migrations failing because of strong_migrations update (#12692)

Fixes #12690

The `strong_migrations` update from ba2eac8824a85aa9541f8070ed7bcd22b9982cc8
introduced a check for `change_column_null` specific to Postgres. This rejects
old migrations.

This commit just wraps old migrations with `safety_assured` to bypass this
check. Alternatives would have been to:
- Disable that check entirely (a possibility added in that same
  `strong_migrations` version) for Mastodon, but it makes sense to write new
  migrations without such a strong lock.
- Rewrite the old migrations to do it in a way that do not require an exclusive
  lock. I thought fixing those old migrations for performance wasn't worth the
  pain. Also, if I understand correctly, the next version of
  `strong_migrations` is going to include a helper to do that. We could update
  those migrations at that point.
db/migrate/20170711225116_fix_null_booleans.rb
db/migrate/20171010025614_change_accounts_nonnullable_in_account_moderation_notes.rb
db/migrate/20171201000000_change_account_id_nonnullable_in_lists.rb
db/migrate/20180310000000_change_columns_in_notifications_nonnullable.rb